All of lore.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: linux-nfs@vger.kernel.org
Cc: "Aurelien Charbon" <aurelien.charbon@bull.net>,
	"Neil Brown" <neilb@suse.de>, "Brian Haley" <brian.haley@hp.com>,
	"YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
Subject: stuff
Date: Fri, 9 May 2008 15:23:19 -0400	[thread overview]
Message-ID: <20080509192319.GG1907@fieldses.org> (raw)

=46rom: J. Bruce Fields <bfields@citi.umich.edu>

Commit f15364bd4cf8799a7677b6daeed7b67d9139d974 ("IPv6 support for NFS
server export caches") dropped a couple spaces, rendering the output
here difficult to read.

(However note that we expect the output to be parsed only by humans, no=
t
machines, so this shouldn't have broken any userland software.)

Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Cc: Aurelien Charbon <aurelien.charbon@bull.net>
Cc: Neil Brown <neilb@suse.de>
Cc: Brian Haley <brian.haley@hp.com>
Cc:  YOSHIFUJI Hideaki / =E5=90=89=E8=97=A4=E8=8B=B1=E6=98=8E <yoshfuji=
@linux-ipv6.org>

---
 net/sunrpc/svcauth_unix.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

I just noticed this while doing some debugging at Connectathon.  I'm
undecided whether to take it seriously.  Does anyone other than me use
these /content files?  I suppose it should probably go into 2.6.26 but
not 2.6.25.x.

--b.

diff --git a/net/sunrpc/svcauth_unix.c b/net/sunrpc/svcauth_unix.c
index 3f30ee6..f24800f 100644
--- a/net/sunrpc/svcauth_unix.c
+++ b/net/sunrpc/svcauth_unix.c
@@ -278,7 +278,7 @@ static int ip_map_show(struct seq_file *m,
 		dom =3D im->m_client->h.name;
=20
 	if (ipv6_addr_v4mapped(&addr)) {
-		seq_printf(m, "%s" NIPQUAD_FMT "%s\n",
+		seq_printf(m, "%s " NIPQUAD_FMT " %s\n",
 			im->m_class,
 			ntohl(addr.s6_addr32[3]) >> 24 & 0xff,
 			ntohl(addr.s6_addr32[3]) >> 16 & 0xff,
@@ -286,7 +286,7 @@ static int ip_map_show(struct seq_file *m,
 			ntohl(addr.s6_addr32[3]) >>  0 & 0xff,
 			dom);
 	} else {
-		seq_printf(m, "%s" NIP6_FMT "%s\n",
+		seq_printf(m, "%s " NIP6_FMT " %s\n",
 			im->m_class, NIP6(addr), dom);
 	}
 	return 0;
--=20
1.5.5.rc1


             reply	other threads:[~2008-05-09 19:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-09 19:23 J. Bruce Fields [this message]
2008-05-09 20:48 ` [PATCH] Fix /proc/net/rpc/auth.unix.ip/content output [Was Re: stuff] J. Bruce Fields
2008-05-12  0:15   ` Neil Brown
     [not found]     ` <18471.35859.781495.449872-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2008-05-12  0:40       ` J. Bruce Fields
  -- strict thread matches above, loose matches on Subject: below --
2023-06-09 21:26 stuff André Albergaria Coelho
2008-04-24 20:34 stuff J. Bruce Fields
2007-07-08 22:29 stuff J. Bruce Fields
2007-07-08 23:07 ` stuff Junio C Hamano
2006-12-28  2:09 stuff Pat Harrison

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080509192319.GG1907@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=aurelien.charbon@bull.net \
    --cc=brian.haley@hp.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.