From: Jean Delvare <khali@linux-fr.org>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
rtc-linux@googlegroups.com, i2c@lm-sensors.org,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
David Brownell <david-b@pacbell.net>
Subject: Re: [RFC][PATCH 2/4] RTC: SWARM I2C board initialization
Date: Fri, 9 May 2008 22:38:45 +0200 [thread overview]
Message-ID: <20080509223845.4a38d751@hyperion.delvare> (raw)
In-Reply-To: <Pine.LNX.4.55.0805092054030.10552@cliff.in.clinika.pl>
Hi Maciej,
On Fri, 9 May 2008 21:27:04 +0100 (BST), Maciej W. Rozycki wrote:
> Well, sorry, but I could only sense the lack of style in this piece of
> code, which is why I tried to apply some.
I agree, i2c-sibyte is very old code, and unmaintained, coding style is
horrible. That's one more reason to not include random style cleanups
in a patch doing functional changes, the improvement will hardly be
visible. If you care about cleaning up the code of this driver - and I
would appreciate that - please make a separate patch.
> You are free to disagree and as
> you have undertaken maintenance of this area I am going to respect it.
And I thank you for that.
--
Jean Delvare
next prev parent reply other threads:[~2008-05-09 20:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-07 0:40 [RFC][PATCH 2/4] RTC: SWARM I2C board initialization Maciej W. Rozycki
2008-05-07 6:59 ` Jean Delvare
2008-05-07 7:08 ` Andrew Morton
2008-05-07 21:13 ` Maciej W. Rozycki
2008-05-08 4:51 ` Ralf Baechle
2008-05-08 22:43 ` Maciej W. Rozycki
2008-05-08 8:59 ` Jean Delvare
2008-05-08 8:59 ` Jean Delvare
2008-05-08 8:59 ` Jean Delvare
2008-05-08 23:10 ` Maciej W. Rozycki
2008-05-09 7:28 ` Jean Delvare
2008-05-09 20:27 ` Maciej W. Rozycki
2008-05-09 20:38 ` Jean Delvare [this message]
2008-05-10 1:43 ` Maciej W. Rozycki
2008-05-07 7:05 ` Jean Delvare
2008-05-07 7:37 ` Geert Uytterhoeven
2008-05-07 7:43 ` Jean Delvare
2008-05-07 21:25 ` Maciej W. Rozycki
2008-05-08 4:57 ` Ralf Baechle
2008-05-08 7:56 ` Jean Delvare
2008-05-09 19:36 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080509223845.4a38d751@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=david-b@pacbell.net \
--cc=i2c@lm-sensors.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=rtc-linux@googlegroups.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.