Re: [patch 2.6.25-git] i2c_adapters: return -Errno not -1

From: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
To: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Cc: i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
Subject: Re: [patch 2.6.25-git] i2c_adapters:  return -Errno not -1
Date: Sun, 11 May 2008 10:16:59 -0700	[thread overview]
Message-ID: <200805111016.59365.david-b@pacbell.net> (raw)
In-Reply-To: <20080510225548.36297637-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>

On Saturday 10 May 2008, Jean Delvare wrote:
> >       amd_ec_write(smbus, AMD_SMB_ADDR, addr << 1);
> >       amd_ec_write(smbus, AMD_SMB_PRTCL, protocol);
> >  
> > +     /* FIXME this discards status from ec_read() ... */
> >       amd_ec_read(smbus, AMD_SMB_STS, temp + 0);
> 
> Same is true of almost all amd_ec_write and amd_ec_read calls, so I
> don't get the point of adding a comment for this one occurrence in
> particular.
> 
> >  
> >       if (~temp[0] & AMD_SMB_STS_DONE) {

I updated that comment.  The issue is that temp[0] will
have random stack garbage at that point, so the rest of
that routine is at best dicey.

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c