From: Jean Delvare <khali@linux-fr.org>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
i2c@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] I2C: SiByte: Mark i2c_sibyte_add_bus() as static
Date: Sun, 11 May 2008 11:07:08 +0200 [thread overview]
Message-ID: <20080511110708.57aedfa6@hyperion.delvare> (raw)
In-Reply-To: <Pine.LNX.4.55.0805110311170.18978@cliff.in.clinika.pl>
On Sun, 11 May 2008 03:14:05 +0100 (BST), Maciej W. Rozycki wrote:
> The i2c_sibyte_add_bus() function is not called, nor meant to, from
> outside, so mark it as static; fixing a sparse warning too.
>
> Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
> ---
> It should be obvious. Please apply.
>
> Maciej
>
> patch-2.6.26-rc1-20080505-sibyte-i2c-sparse-16
> diff -up --recursive --new-file linux-2.6.26-rc1-20080505.macro/drivers/i2c/busses/i2c-sibyte.c linux-2.6.26-rc1-20080505/drivers/i2c/busses/i2c-sibyte.c
> --- linux-2.6.26-rc1-20080505.macro/drivers/i2c/busses/i2c-sibyte.c 2008-05-05 02:55:25.000000000 +0000
> +++ linux-2.6.26-rc1-20080505/drivers/i2c/busses/i2c-sibyte.c 2008-05-11 01:11:00.000000000 +0000
> @@ -132,7 +132,7 @@ static const struct i2c_algorithm i2c_si
> /*
> * registering functions to load algorithms at runtime
> */
> -int __init i2c_sibyte_add_bus(struct i2c_adapter *i2c_adap, int speed)
> +static int __init i2c_sibyte_add_bus(struct i2c_adapter *i2c_adap, int speed)
> {
> struct i2c_algo_sibyte_data *adap = i2c_adap->algo_data;
>
Applied, thanks.
--
Jean Delvare
prev parent reply other threads:[~2008-05-11 9:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-11 2:14 [PATCH] I2C: SiByte: Mark i2c_sibyte_add_bus() as static Maciej W. Rozycki
2008-05-11 2:14 ` Maciej W. Rozycki
2008-05-11 9:07 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080511110708.57aedfa6@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=akpm@linux-foundation.org \
--cc=i2c@lm-sensors.org \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.