From: Ivo van Doorn <ivdoorn@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, rt2400-devel@lists.sourceforge.net
Subject: Re: [PATCH 4/5] rt2x00: Convert rt2x00 to read control info from skb->cb
Date: Sun, 11 May 2008 11:13:52 +0200 [thread overview]
Message-ID: <200805111113.53138.IvDoorn@gmail.com> (raw)
In-Reply-To: <1210454412.12837.16.camel@johannes.berg>
On Saturday 10 May 2008, Johannes Berg wrote:
>
> > + /*
> > + * Don't automatically kick the beacon queue.
> > + */
> > + tx_info->flags &= ~IEEE80211_TX_CTL_READY_FOR_TX;
> >
> > /*
> > * Fill in skb descriptor
> > */
> > skbdesc = get_skb_frame_desc(skb);
> > memset(skbdesc, 0, sizeof(*skbdesc));
> > - skbdesc->flags |= FRAME_DESC_DRIVER_GENERATED;
>
> Could you live w/o that change? I'm pondering removing that flag again
> since it doesn't have any meaning any more with the fragmentation/busy
> reschedule rewrite I'll do.
Not a problem, I had already removed a few instances where I used that,
and will remove the remaining bits as well.
Ivo
next prev parent reply other threads:[~2008-05-11 9:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-10 11:49 [PATCH 0/5] mac80211 & rt2x00 updates Ivo van Doorn
2008-05-10 11:49 ` [PATCH 1/5] rt2x00: use rate index in TX control Ivo van Doorn
2008-05-10 11:50 ` [PATCH 3/5] rt2x00: use multi-queue master netdevice Ivo van Doorn
2008-05-10 11:50 ` [PATCH 2/5] mac80211: Initialize sta pointer Ivo van Doorn
2008-05-10 16:22 ` Johannes Berg
2008-05-10 11:51 ` [PATCH 4/5] rt2x00: Convert rt2x00 to read control info from skb->cb Ivo van Doorn
2008-05-10 21:20 ` Johannes Berg
2008-05-11 9:13 ` Ivo van Doorn [this message]
2008-05-11 11:33 ` Ivo van Doorn
2008-05-11 11:49 ` Johannes Berg
2008-05-11 12:13 ` Ivo van Doorn
2008-05-10 11:51 ` [PATCH 5/5] mac80211: Match define names in comments with actual defines Ivo van Doorn
2008-05-10 16:21 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805111113.53138.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=rt2400-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.