All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Sam Ravnborg <sam@ravnborg.org>,
	Mikael Pettersson <mikpe@it.uu.se>, Pavel Machek <pavel@ucw.cz>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	tglx@linutronix.de, mingo@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: 2.6.26-rc1 on x86: ld: warning: dot moved backwards before `.text'
Date: Sun, 11 May 2008 22:29:05 +0400	[thread overview]
Message-ID: <20080511182905.GD6942@cvg> (raw)
In-Reply-To: <48273A32.5020104@zytor.com>

[H. Peter Anvin - Sun, May 11, 2008 at 11:25:54AM -0700]
> Cyrill Gorcunov wrote:
>> Hi Peter,
>> actually I only doubt about exactly position of this headers - I mean
>> meguess it better should be _before_ "_end" not after. Since the others
>> script uses (acpi/wakeup_rm.S):
>> 	wakeup_code_start:
>> 	.incbin	"arch/x86/kernel/acpi/realmode/wakeup.bin"
>> 	wakeup_code_end:
>> and kernel uses these wakeup_code_* marks to save/restore memory I think
>> it should be like
>> 	. = HEADER_OFFSET;
>> 	.header : {
>> 		...
>> 	}
>> 	. = ALIGN(16);
>> 	_end = .;
>> 	/DISCARD/ ...
>
> Yes, I believe that's correct.
>
> 	-hpa
>

Thanks for review, Peter, I'll cook a patch and wait for
Pavel's opinion ;-)

		- Cyrill -

  reply	other threads:[~2008-05-11 18:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-10 20:18 2.6.26-rc1 on x86: ld: warning: dot moved backwards before `.text' Mikael Pettersson
2008-05-10 20:23 ` Rafael J. Wysocki
2008-05-10 20:25 ` H. Peter Anvin
2008-05-10 20:56   ` Rafael J. Wysocki
2008-05-11 18:52     ` Pavel Machek
2008-05-10 21:16   ` Sam Ravnborg
2008-05-11 15:44     ` Cyrill Gorcunov
2008-05-11 18:15       ` H. Peter Anvin
2008-05-11 18:24         ` Cyrill Gorcunov
2008-05-11 18:25           ` H. Peter Anvin
2008-05-11 18:29             ` Cyrill Gorcunov [this message]
2008-05-11 21:22               ` Rafael J. Wysocki
2008-05-12  4:15                 ` Cyrill Gorcunov
2008-05-12  6:16                   ` Cyrill Gorcunov
2008-05-12  6:52                 ` Pavel Machek
2008-05-11 18:54       ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080511182905.GD6942@cvg \
    --to=gorcunov@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikpe@it.uu.se \
    --cc=mingo@redhat.com \
    --cc=pavel@ucw.cz \
    --cc=rjw@sisk.pl \
    --cc=sam@ravnborg.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.