From: Sascha Hauer <s.hauer@pengutronix.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [Patch] U-Boot-V2: Sandbox: remove unwanted compiler flags
Date: Mon, 12 May 2008 11:47:55 +0200 [thread overview]
Message-ID: <20080512094755.GC4464@pengutronix.de> (raw)
In-Reply-To: <4823A49D.9070301@gmail.com>
On Thu, May 08, 2008 at 08:10:53PM -0500, Nishanth Menon wrote:
> The following patch removes global compilation flags duplicated in
> sandbox makefile.
> This also works-around a probable compiler issue noted in my mail here:
> http://sourceforge.net/mailarchive/forum.php?thread_name=48193193.30508%40gmail.com&forum_name=u-boot-users
>
> Signed-off-by: Nishanth Menon <x0nishan@ti.com>
This patch does the right thing generally, I did not apply it for one
reason: There are many compiler options which should be in the toplevel
Makefile instead of the architecture Makefiles. I also realized that
CFLAGS get overwritten in the architecture Makefiles instead of
appended, so there are some more things to fix. May I ask you to keep
your patch for another three weeks? Then we have our
Pengutronix-hacking-week (tm) and I expect to do some general U-Boot
work then.
Sascha
>
> Index: u-boot.v2/arch/sandbox/Makefile
> ===================================================================
> --- u-boot.v2.orig/arch/sandbox/Makefile 2008-05-08
> 19:48:10.000000000 -0500
> +++ u-boot.v2/arch/sandbox/Makefile 2008-05-08 19:49:58.000000000 -0500
> @@ -1,5 +1,5 @@
>
> -CPPFLAGS += -fno-builtin -ffreestanding -nostdinc -Wall \
> +CPPFLAGS += -fno-builtin -ffreestanding\
> -pipe -fno-strict-aliasing
>
> machine-y := sandbox
> @@ -11,7 +11,7 @@
> TEXT_BASE = $(CONFIG_TEXT_BASE)
>
> CPPFLAGS += -P
> -CFLAGS := -fno-common -Os -Dmalloc=u_boot_malloc \
> +CFLAGS := -Os -Dmalloc=u_boot_malloc \
> -Dfree=u_boot_free -Drealloc=u_boot_realloc \
> -Dread=u_boot_read -Dwrite=u_boot_write \
> -Dopen=u_boot_open -Dclose=u_boot_close \
>
>
--
Pengutronix e.K. - Linux Solutions for Science and Industry
-----------------------------------------------------------
Kontakt-Informationen finden Sie im Header dieser Mail oder
auf der Webseite -> http://www.pengutronix.de/impressum/ <-
prev parent reply other threads:[~2008-05-12 9:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-09 1:10 [U-Boot-Users] [Patch] U-Boot-V2: Sandbox: remove unwanted compiler flags Nishanth Menon
2008-05-12 9:47 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080512094755.GC4464@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.