From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 12 May 2008 10:50:11 -0700 From: Stephen Hemminger Message-ID: <20080512105011.7070c249@extreme> In-Reply-To: <1210585065.32216.218.camel@gentoo-jocke.transmode.se> References: <1210152122.32216.95.camel@gentoo-jocke.transmode.se> <2e59e6970805071916r701987fdx49bab341420ba2d@mail.gmail.com> <1210233718.32216.121.camel@gentoo-jocke.transmode.se> <4822C20B.3050303@sysnetsistemi.it> <1210240896.32216.146.camel@gentoo-jocke.transmode.se> <4822EE5C.8030404@sysnetsistemi.it> <1210251508.32216.160.camel@gentoo-jocke.transmode.se> <1210585065.32216.218.camel@gentoo-jocke.transmode.se> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] STP bug, loop not detetcted List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: joakim.tjernlund@transmode.se Cc: bridge@lists.linux-foundation.org On Mon, 12 May 2008 11:37:45 +0200 Joakim Tjernlund wrote: > > On Thu, 2008-05-08 at 14:58 +0200, Joakim Tjernlund wrote: > > On Thu, 2008-05-08 at 14:13 +0200, Francesco Dolcini wrote: > > > Joakim Tjernlund wrote: > > > > On Thu, 2008-05-08 at 11:04 +0200, Francesco Dolcini wrote: > > > >> cisco and others solved this kind of problem using proprietary > > > >> unidirectional link detection protocols (see cisco informational rfc > > > >> 5171 for example). No standard exists as far as I know (BFD rfc does not > > > >> consider the layer 2 case). > > > > > > > > Are these proprietary unidirectional link detection protocols the only > > > > way to solve the problem? > > > spanning tree protocol, in the various IEEE incarnation (802.1D, 802.1Q) > > > and cisco (PVSTP) does not handle this problem, so an external mechanism > > > is needed. > > > > Do they explicitly ban it? Otherwise I don't see why not the kernel STP > > can be enchanted. You could even view it as an external mechanism. > > > > > > > > > Would STP break if the interface was set to "non forwarding" in this > > > > case until the bridge stops seeing its own STP messages? > > > At least this will not solve the more general problem of a > > > unidirectional link (rx working and tx broken). > > > > hmm, if TX is broken there won't be a loop anyway? > > > > Anyhow, even if my proposed change doesn't solve all cases it seems like > > a useful, very simple, ad don to STP. I am just concerned that it can > > break some other aspect of STP. So far it seems OK. > > > > What is the bridge maintainers view on this? > > Stephen, whats is your view about extending the bridge code according to > above? Also, after looking at the bride code I don't see where this > should be added, I must be getting old :( > > Jocke If you want to make STP vlan aware, then fine, a good place to start is getting a version of new RSTP and making it vlan aware.