From: Ivo van Doorn <ivdoorn@gmail.com>
To: johannes@sipsolutions.net
Cc: David Miller <davem@davemloft.net>, linux-wireless@vger.kernel.org
Subject: Re: [RFT/C 7/7] mac80211: move TX info into skb->cb
Date: Mon, 12 May 2008 14:26:12 +0200 [thread overview]
Message-ID: <200805121426.12656.IvDoorn@gmail.com> (raw)
In-Reply-To: <20080512.021145.265455571.davem@davemloft.net>
On Monday 12 May 2008, David Miller wrote:
> From: Johannes Berg <johannes@sipsolutions.net>
> Date: Sun, 11 May 2008 00:18:52 +0200
>
> > This patch converts mac80211 and all drivers to have transmit
> > information and status in skb->cb rather than allocating extra
> > memory for it and copying all the data around. To make it fit,
> > a union is used where only data that is necessary for all steps
> > is kept outside of the union.
> >
> > A number of fixes were done by Ivo, as well as the rt2x00 part
> > of this patch.
> >
> > Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
> > Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
>
> Please create an IEEE80211_SKB_CB() or similar macro to wrap
> these casts around with, like all other SKB CB users do.
Johannes, I have such a function in rt2x00queue.h:
static inline struct ieee80211_tx_info* get_skb_tx_info(struct sk_buff *skb)
{
return (struct ieee80211_tx_info *)skb->cb;
}
You could rename it and move that one into mac80211.h
Ivo
next prev parent reply other threads:[~2008-05-12 12:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-10 22:18 [RFT/C 0/7] various mac80211 updates/bugfixes Johannes Berg
2008-05-10 22:18 ` [RFT/C 1/7] mac80211: use skb_header_cloned() Johannes Berg
2008-05-12 9:09 ` David Miller
2008-05-10 22:18 ` [RFT/C 2/7] mac80211: clean up skb reallocation code Johannes Berg
2008-05-12 9:09 ` David Miller
2008-05-13 8:39 ` Johannes Berg
2008-05-13 8:39 ` David Miller
2008-05-10 22:18 ` [RFT/C 3/7] mac80211: fix bugs in queue handling functions Johannes Berg
2008-05-10 22:18 ` [RFT/C 4/7] mac80211: let drivers wake but not start queues Johannes Berg
2008-05-12 9:10 ` David Miller
2008-05-10 22:18 ` [RFT/C 5/7] mac80211: use rate index in TX control Johannes Berg
2008-05-10 22:18 ` [RFT/C 6/7] mac80211: reorder some transmit handlers Johannes Berg
2008-05-10 22:18 ` [RFT/C 7/7] mac80211: move TX info into skb->cb Johannes Berg
2008-05-12 9:11 ` David Miller
2008-05-12 12:26 ` Ivo van Doorn [this message]
2008-05-13 8:40 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805121426.12656.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.