From: Theodore Tso <tytso@mit.edu>
To: "Jose R. Santos" <jrs@us.ibm.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [RFC PATCH 4/9][e2fsprogs] Add 64-bit alloc_stats interface.
Date: Mon, 12 May 2008 10:43:53 -0400 [thread overview]
Message-ID: <20080512144353.GC7029@mit.edu> (raw)
In-Reply-To: <20080509163952.15484.56168.stgit@gara>
On Fri, May 09, 2008 at 11:39:52AM -0500, Jose R. Santos wrote:
> + /*FIXME: Not blk64_t clean */
Suggestion, please use "FIXME-64" instead of fixme so it's easier to
clean this up later.
> int group = ext2fs_group_of_blk(fs, blk);
Might as well fix this in the initial patch series, earlier --- and
let's *not* make it be an inline function. Yeah, we call
ext2fs_group_of_blk and ext2fs_group_of_ino a fair amount, but #1, on
32-bit machines, the 64 bit arithmemtic makes the function bigger, and
#2, modern CPU's have greatly reduced the cost of procedure
activations.
- Ted
next prev parent reply other threads:[~2008-05-12 14:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-09 16:39 [RFC PATCH 0/9][e2fsprogs] Initial blk64_t capable API calls Jose R. Santos
2008-05-09 16:39 ` [RFC PATCH 1/9][e2fsprogs] Add ext2_off64_t type Jose R. Santos
2008-05-09 16:39 ` [RFC PATCH 2/9][e2fsprogs] Use blk64_t for blocks in struct ext2_file Jose R. Santos
2008-05-09 16:39 ` [RFC PATCH 3/9][e2fsprogs] Add 64-bit dirblock interface Jose R. Santos
2008-05-09 16:39 ` [RFC PATCH 4/9][e2fsprogs] Add 64-bit alloc_stats interface Jose R. Santos
2008-05-12 14:43 ` Theodore Tso [this message]
2008-05-12 17:25 ` Jose R. Santos
2008-05-09 16:39 ` [RFC PATCH 5/9][e2fsprogs] Add 64-bit alloc interface Jose R. Santos
2008-05-09 16:40 ` [RFC PATCH 6/9][e2fsprogs] Add 64-bit ext_attr interface Jose R. Santos
2008-05-12 14:47 ` Theodore Tso
2008-05-09 16:40 ` [RFC PATCH 7/9][e2fsprogs] Add new blk64_t handling inline functions Jose R. Santos
2008-05-12 14:49 ` Theodore Tso
2008-05-12 17:25 ` Jose R. Santos
2008-05-12 19:22 ` Theodore Tso
2008-05-09 16:40 ` [RFC PATCH 8/9][e2fsprogs] Add 64-bit closefs interface Jose R. Santos
2008-05-12 15:05 ` Theodore Tso
2008-05-12 17:24 ` Jose R. Santos
2008-05-12 19:29 ` Theodore Tso
2008-05-09 16:40 ` [RFC PATCH 9/9][e2fsprogs] Add 64-bit openfs interface Jose R. Santos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080512144353.GC7029@mit.edu \
--to=tytso@mit.edu \
--cc=jrs@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.