All of lore.kernel.org
 help / color / mirror / Atom feed
From: rmccabe@sourceware.org <rmccabe@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] conga/luci cluster/resource-form-macros site/l ...
Date: 12 May 2008 18:04:12 -0000	[thread overview]
Message-ID: <20080512180412.29462.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/cluster
Module name:	conga
Branch: 	RHEL4
Changes by:	rmccabe at sourceware.org	2008-05-12 18:04:12

Modified files:
	luci/cluster   : resource-form-macros 
	luci/site/luci/Extensions: ResourceHandler.py 

Log message:
	Allow users to choose GFS or GFS2 fstype for clusterfs resources

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/luci/cluster/resource-form-macros.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.31.2.11&r2=1.31.2.12
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/luci/site/luci/Extensions/ResourceHandler.py.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.2.2.5&r2=1.2.2.6

--- conga/luci/cluster/resource-form-macros	2008/04/28 03:57:41	1.31.2.11
+++ conga/luci/cluster/resource-form-macros	2008/05/12 18:04:12	1.31.2.12
@@ -631,6 +631,19 @@
 		</tr>
 
 		<tr class="systemsTable">
+			<td class="systemsTable">Filesystem type</td>
+			<td class="systemsTable"
+				tal:define="cur_fstype res/attrs/fstype | string:gfs">
+
+				<input type="radio" name="fstype" value="gfs"
+					tal:attributes="checked python:cur_fstype.lower() == 'gfs' and 'checked' or ''" />GFS
+				<br/>
+				<input type="radio" name="fstype" value="gfs2"
+					tal:attributes="checked python:cur_fstype.lower() == 'gfs2' and 'checked' or ''" />GFS2
+			</td>
+		</tr>
+
+		<tr class="systemsTable">
 			<td class="systemsTable">Options</td>
 			<td class="systemsTable">
 				<input type="text" size="20" name="options"
--- conga/luci/site/luci/Extensions/ResourceHandler.py	2008/04/29 16:09:26	1.2.2.5
+++ conga/luci/site/luci/Extensions/ResourceHandler.py	2008/05/12 18:04:12	1.2.2.6
@@ -191,6 +191,19 @@
 			luci_log.debug_verbose('addGfs6: %s' % err)
 
 	try:
+		fstype = form['fstype'].lower().strip()
+		if not fstype:
+			raise KeyError, 'No filesystem type was given'
+		if fstype != 'gfs' and fstype != 'gfs2':
+			raise KeyError, 'An invalid file system type of "%s" was given' % fstype
+		res.addAttribute('fstype', fstype)
+	except Exception, e:
+		err = str(e)
+		errors.append(err)
+		if LUCI_DEBUG_MODE is True:
+			luci_log.debug_verbose('addGfs7a: %s' % err)
+
+	try:
 		options = form['options'].strip()
 		if not options:
 			raise KeyError, 'no options'



             reply	other threads:[~2008-05-12 18:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-12 18:04 rmccabe [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-03-25 20:01 [Cluster-devel] conga/luci cluster/resource-form-macros site/l rmccabe
2010-08-07  3:16 rmccabe
2008-05-12 18:03 rmccabe
2007-05-30 22:39 rmccabe
2007-02-22 20:52 rmccabe
2007-02-22 20:52 rmccabe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080512180412.29462.qmail@sourceware.org \
    --to=rmccabe@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.