From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Jvd0C-0002GD-Er for mharc-grub-devel@gnu.org; Mon, 12 May 2008 14:44:00 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jvd0B-0002Fx-7J for grub-devel@gnu.org; Mon, 12 May 2008 14:43:59 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jvd09-0002Fl-Ln for grub-devel@gnu.org; Mon, 12 May 2008 14:43:58 -0400 Received: from [199.232.76.173] (port=40989 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jvd09-0002Fi-I8 for grub-devel@gnu.org; Mon, 12 May 2008 14:43:57 -0400 Received: from aybabtu.com ([69.60.117.155]:56464) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Jvd08-0006rE-4q for grub-devel@gnu.org; Mon, 12 May 2008 14:43:57 -0400 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1Jvd06-0000sJ-CK for grub-devel@gnu.org; Mon, 12 May 2008 20:43:54 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JvczS-0005GB-Ue for grub-devel@gnu.org; Mon, 12 May 2008 20:43:15 +0200 Date: Mon, 12 May 2008 20:43:14 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080512184314.GA11847@thorin> References: <481590B8.7000405@gmail.com> <20080429134626.GB8328@thorin> <481DC1BC.6020002@gmail.com> <20080506133126.GG5055@thorin> <4826DA0D.9070302@gmail.com> <20080512154409.GD1841@thorin> <48286A26.2090202@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <48286A26.2090202@gmail.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Bug#478238: grub-probe: fails to find drive for /dev/sda10 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 May 2008 18:43:59 -0000 On Mon, May 12, 2008 at 07:02:46PM +0300, Török Edwin wrote: > Robert Millan wrote: > > On Sun, May 11, 2008 at 02:35:41PM +0300, Török Edwin wrote: > > > >> /dev/sda9 is not a valid OpenBSD partition, and in partmap/pc.c:176 the > >> iteration fails with an error: invalid disk label magic 0x%x. > >> If I replace that return with a continue, it works. > >> > >> The problem is that grub2 stops looking for more partitions as soon as > >> it encountered the invalid partition, > >> > > > > I think a correct fix for this belongs in grub_partition_iterate(). It should > > only let its hook determine abortability rather than mandate that invalid > > partitions should cause abortion. Please, can you test the attached patch? > > > > I tested the patch, however it still says: > grub-probe: error: Cannot find a GRUB drive for /dev/sda10. Check your > device.map. > > I notice that /dev/sda10 appears in the -vv output though: > home/egrub-probe: info: opening the device `/dev/sda9' > grub-probe: info: opening the device `/dev/sda9' > grub-probe: info: /dev/sda10 starts from 83987883 > grub-probe: info: opening the device hd0 > > I attached the full output of grub-probe -d /dev/sda10 -vv, for the case > when /dev/sda9 has the wrong partition type. It's better is you use grub-emu for this test. It's less complex. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)