All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Stezenbach <js@linuxtv.org>
To: Oliver Endriss <o.endriss@gmx.de>
Cc: Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org,
	Mauro Carvalho Chehab <mchehab@infradead.org>,
	Andrew de Quincey <adq_dvb@lidskialf.net>
Subject: Re: [patch, 2.6.26-rc2] dvb: drivers/media/dvb/ttpci/fdump firmware build error fix
Date: Mon, 12 May 2008 21:46:30 +0200	[thread overview]
Message-ID: <20080512194630.GA10174@linuxtv.org> (raw)
In-Reply-To: <200805121930.10909@orion.escape-edv.de>

On Mon, May 12, 2008 at 07:30:10PM +0200, Oliver Endriss wrote:
> Ingo Molnar wrote:
>> -     depends on DVB_AV7110 && !STANDALONE
>> +     depends on DVB_AV7110 && !STANDALONE && !PREVENT_FIRMWARE_BUILD

> If you set DVB_AV7110_FIRMWARE=y, the firmware file under
> DVB_AV7110_FIRMWARE_FILE must exist...

The point of PREVENT_FIRMWARE_BUILD is to make build testing
with "make randconfig" possible. I think you should ACK
this patch, it doesn't have any downsides for users of
this driver.

Johannes

  reply	other threads:[~2008-05-12 20:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-12 10:12 [patch, 2.6.26-rc2] dvb: drivers/media/dvb/ttpci/fdump firmware build error fix Ingo Molnar
2008-05-12 17:30 ` Oliver Endriss
2008-05-12 19:46   ` Johannes Stezenbach [this message]
2008-05-12 20:18     ` Oliver Endriss
2008-05-12 20:30       ` Oliver Endriss
2008-05-12 20:46       ` Johannes Stezenbach
2008-05-13  9:50         ` Ingo Molnar
2008-05-13 14:33         ` Oliver Endriss
2008-05-13 14:49           ` Ingo Molnar
2008-05-13 15:23           ` Johannes Stezenbach
     [not found]             ` <20080513163930.GB21678@elte.hu>
2008-05-13 16:42               ` Ingo Molnar
2008-05-13 18:18                 ` Johannes Stezenbach
2008-05-13 23:49                   ` Oliver Endriss
     [not found]           ` <20080513163647.GA21678@elte.hu>
2008-05-13 16:41             ` Ingo Molnar
2008-05-13 17:01               ` Johannes Stezenbach
2008-05-14  0:55               ` Oliver Endriss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080512194630.GA10174@linuxtv.org \
    --to=js@linuxtv.org \
    --cc=adq_dvb@lidskialf.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=mingo@elte.hu \
    --cc=o.endriss@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.