From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Chris Malley <mail@chrismalley.co.uk>
Cc: Alan Cox <alan@redhat.com>, linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH] riscom8: remove redundant null pointer test
Date: Mon, 12 May 2008 20:58:23 +0100 [thread overview]
Message-ID: <20080512205823.23adc6f1@core> (raw)
In-Reply-To: <1210616830.7454.0.camel@localhost>
On Mon, 12 May 2008 19:27:10 +0100
Chris Malley <mail@chrismalley.co.uk> wrote:
> tty has already been dereferenced at least twice in these functions,
> so checking for null here seems a bit unnecessary.
Oh it is - and lots of the other tty checks are bogus too.
Acked-by: Alan Cox <alan@redhat.com>
Alan
prev parent reply other threads:[~2008-05-12 20:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-12 18:27 [PATCH] riscom8: remove redundant null pointer test Chris Malley
2008-05-12 19:58 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080512205823.23adc6f1@core \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@chrismalley.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.