From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757584AbYELUbS (ORCPT ); Mon, 12 May 2008 16:31:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753765AbYELUbI (ORCPT ); Mon, 12 May 2008 16:31:08 -0400 Received: from mail.gmx.net ([213.165.64.20]:40495 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751660AbYELUbG (ORCPT ); Mon, 12 May 2008 16:31:06 -0400 X-Authenticated: #476490 X-Provags-ID: V01U2FsdGVkX1/NIAUQh4rNEM0CPbBY992QRIuw0/o+eEe7RkD/mm FRYRckoFEzNyCf From: Oliver Endriss Organization: ESCAPE GmbH EDV-Loesungen To: Johannes Stezenbach Subject: Re: [patch, 2.6.26-rc2] dvb: drivers/media/dvb/ttpci/fdump firmware build error fix Date: Mon, 12 May 2008 22:30:41 +0200 User-Agent: KMail/1.9.6 Cc: Ingo Molnar , linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , Andrew de Quincey References: <20080512101231.GA11755@elte.hu> <20080512194630.GA10174@linuxtv.org> <200805122218.15887@orion.escape-edv.de> In-Reply-To: <200805122218.15887@orion.escape-edv.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200805122230.42235@orion.escape-edv.de> X-Y-GMX-Trusted: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Oliver Endriss wrote: > Johannes Stezenbach wrote: > > On Mon, May 12, 2008 at 07:30:10PM +0200, Oliver Endriss wrote: > > > Ingo Molnar wrote: > > >> - depends on DVB_AV7110 && !STANDALONE > > >> + depends on DVB_AV7110 && !STANDALONE && !PREVENT_FIRMWARE_BUILD > > > > > If you set DVB_AV7110_FIRMWARE=y, the firmware file under > > > DVB_AV7110_FIRMWARE_FILE must exist... > > > > The point of PREVENT_FIRMWARE_BUILD is to make build testing > > with "make randconfig" possible. I think you should ACK > > this patch, it doesn't have any downsides for users of > > this driver. > > No. If randconfig deselects both STANDALONE and PREVENT_FIRMWARE_BUILD, > the same problem will happen again... > > The problem is that randconfig does not know what to do (i.e. provide a > firmware file) when it selects DVB_AV7110_FIRMWARE=y. > > The driver depends on STANDALONE, and that should be sufficient: Sorry, typo: The driver depends on !STANDALONE... > | CONFIG_STANDALONE: > | Select this option if you don't have magic firmware for drivers that > | need it. > > while CONFIG_PREVENT_FIRMWARE_BUILD means: > | CONFIG_PREVENT_FIRMWARE_BUILD: > | Say yes to avoid building firmware. Firmware is usually shipped > | with the driver, and only when updating the firmware a rebuild > | should be made. > > Imho randconfig should always set STANDALONE=y. CU Oliver -- ---------------------------------------------------------------- VDR Remote Plugin 0.4.0: http://www.escape-edv.de/endriss/vdr/ ----------------------------------------------------------------