From: Ralf Baechle <ralf@linux-mips.org>
To: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>
Cc: Theodore Tso <tytso@mit.edu>, Martin Michlmayr <tbm@cyrius.com>,
linux-mips@linux-mips.org, linux-ext4@vger.kernel.org
Subject: Re: ext4dev build failure on mips: "empty_zero_page" undefined
Date: Tue, 13 May 2008 06:12:52 +0100 [thread overview]
Message-ID: <20080513051252.GA20575@linux-mips.org> (raw)
In-Reply-To: <20080513045028.GC22226@linux-mips.org>
On Tue, May 13, 2008 at 05:50:29AM +0100, Ralf Baechle wrote:
> > Normally I push my patches via the mips tree, and now I'm Cc:ing Ralf for that.
> >
> > Hopefully Ralf will react quickly. :)
>
> I prefer to do it myself so I can apply it at the same time to the MIPS
> -stable branches.
>
> I'm a little irriated that this thread seems to be only about
> empty_zero_page but apparently not zero_page_mask? empty_zero_page is
> actualy an array of pages on MIPS and ZERO_PAGE() will pick the right one
> for a particular user space mapping based on the virtual address but
> ZERO_PAGE() also references zero_page_mask. So I sense more brokenness
> here.
The ZERO_PAGE(0) call in ext4_ext_zeroout is the culprit. Using a zero
argument allows the compiler to eleminate the reference to zero_page_mask.
Am I reading this right that ZERO_PAGE() is being used without any
mappings to userspace being involved?
Ralf
next prev parent reply other threads:[~2008-05-13 5:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-12 13:06 ext4dev build failure on mips: "empty_zero_page" undefined Martin Michlmayr
2008-05-12 13:54 ` Dmitri Vorobiev
2008-05-12 14:34 ` Theodore Tso
2008-05-12 14:46 ` Dmitri Vorobiev
2008-05-13 4:50 ` Ralf Baechle
2008-05-13 5:12 ` Ralf Baechle [this message]
2008-05-15 13:39 ` Theodore Tso
2008-05-28 7:06 ` Martin Michlmayr
2008-06-05 11:11 ` Martin Michlmayr
2008-06-05 11:22 ` Dmitri Vorobiev
2008-06-05 18:38 ` Theodore Tso
2008-06-05 21:34 ` Vorobiev Dmitri
2008-06-05 21:51 ` Thiemo Seufer
2008-06-06 6:57 ` Dmitri Vorobiev
2008-06-06 13:15 ` Theodore Tso
2008-05-12 14:58 ` Martin Michlmayr
2008-05-12 15:14 ` Dmitri Vorobiev
2008-05-12 17:35 ` Theodore Tso
2008-05-12 19:37 ` Dmitri Vorobiev
2008-05-13 0:55 ` Stephen Rothwell
2008-05-13 1:42 ` Stephen Rothwell
2008-05-13 4:23 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080513051252.GA20575@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=dmitri.vorobiev@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=tbm@cyrius.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.