From: Ingo Molnar <mingo@elte.hu>
To: Christoph Lameter <clameter@sgi.com>
Cc: Sam Ravnborg <sam@ravnborg.org>,
linux-kernel@vger.kernel.org, travis@sgi.com,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [patch 6/6] x86: Add checks for virtual addresses in __phys_addr()
Date: Tue, 13 May 2008 14:27:01 +0200 [thread overview]
Message-ID: <20080513122701.GA14973@elte.hu> (raw)
In-Reply-To: <Pine.LNX.4.64.0805092007110.24814@schroedinger.engr.sgi.com>
* Christoph Lameter <clameter@sgi.com> wrote:
> We also need to address this issue with __pa expected to be a constant
> in 32 bit code. Sigh.
hm, even with all the fixlets it breaks with:
http://redhat.com/~mingo/misc/config-Tue_May_13_14_17_44_CEST_2008.bad
arch/x86/kernel/e820_32.c:586: error: static declaration of 'print_memory_map' follows non-static declaration
include/asm/e820.h:75: error: previous declaration of 'print_memory_map' was here
Ingo
prev parent reply other threads:[~2008-05-13 12:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-10 2:09 [patch 0/6] x86: Unification patches etc Christoph Lameter
2008-05-10 2:09 ` [patch 1/6] x86: Unify current.h Christoph Lameter
2008-05-13 12:28 ` Ingo Molnar
2008-05-10 2:09 ` [patch 2/6] x86: e820.h unification Christoph Lameter
2008-05-10 2:09 ` [patch 3/6] x86: e820 unification: Extract shared comments Christoph Lameter
2008-05-10 2:09 ` [patch 4/6] x86: e820 unification: Common #ifdef __ASSEMBLY Christoph Lameter
2008-05-10 2:09 ` [patch 5/6] x86: e820 unification: Extract common functions Christoph Lameter
2008-05-10 2:09 ` [patch 6/6] x86: Add checks for virtual addresses in __phys_addr() Christoph Lameter
2008-05-10 2:23 ` Sam Ravnborg
2008-05-10 2:33 ` Christoph Lameter
2008-05-10 3:07 ` Christoph Lameter
2008-05-13 12:27 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080513122701.GA14973@elte.hu \
--to=mingo@elte.hu \
--cc=clameter@sgi.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.