From: Andrew Morton <akpm@linux-foundation.org>
To: menage@google.com
Cc: pj@sgi.com, xemul@openvz.org, balbir@in.ibm.com,
serue@us.ibm.com, linux-kernel@vger.kernel.org,
containers@lists.linux-foundation.org
Subject: Re: [RFC/PATCH 3/8]: CGroup Files: Move the release_agent file to use typed handlers
Date: Tue, 13 May 2008 13:08:33 -0700 [thread overview]
Message-ID: <20080513130833.cc03caea.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080513071522.470099000@menage.corp.google.com>
On Mon, 12 May 2008 23:37:10 -0700
menage@google.com wrote:
> + agentbuf = kmalloc(PATH_MAX, GFP_KERNEL);
> + if (!agentbuf)
> + goto continue_free;
> + strcpy(agentbuf, cgrp->root->release_agent_path);
Did we need to allocate all that memory, or would kstrdup() suffice?
next prev parent reply other threads:[~2008-05-13 20:09 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-13 6:37 [RFC/PATCH 0/8]: CGroup Files: Clean up locking and boilerplate menage-hpIqsD4AKlfQT0dZR+AlfA
2008-05-13 6:37 ` menage
2008-05-13 6:37 ` [RFC/PATCH 1/8]: CGroup Files: Add locking mode to cgroups control files menage-hpIqsD4AKlfQT0dZR+AlfA
2008-05-13 6:37 ` menage
2008-05-13 9:23 ` Li Zefan
[not found] ` <48295E11.2000003-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2008-05-13 21:07 ` Paul Menage
2008-05-13 21:07 ` Paul Menage
[not found] ` <6599ad830805131407y3d94016cn773ba21a42b6098c-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-05-14 1:30 ` Li Zefan
2008-05-14 1:30 ` Li Zefan
2008-05-14 1:40 ` Paul Menage
[not found] ` <482A40C0.8030708-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2008-05-14 1:40 ` Paul Menage
[not found] ` <20080513071522.133586000-B63HFAS8fGlSzHKm+aFRNNkmqwFzkYv6@public.gmane.org>
2008-05-13 9:23 ` Li Zefan
2008-05-13 20:01 ` Andrew Morton
2008-05-13 20:01 ` Andrew Morton
2008-05-13 20:38 ` Matthew Helsley
[not found] ` <1210711138.21217.49.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-05-13 20:43 ` Andrew Morton
2008-05-13 20:43 ` Andrew Morton
[not found] ` <20080513130127.fcd46a41.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-05-13 20:38 ` Matthew Helsley
2008-05-13 21:17 ` Paul Menage
2008-05-13 21:17 ` Paul Menage
[not found] ` <6599ad830805131417m4f8cc2e6iac42c0fb089a8cb1-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-05-13 21:32 ` Andrew Morton
2008-05-13 21:32 ` Andrew Morton
2008-05-13 21:46 ` Paul Menage
[not found] ` <20080513143206.ef259829.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-05-13 21:46 ` Paul Menage
2008-05-14 1:59 ` Paul Jackson
2008-05-14 1:59 ` Paul Jackson
2008-05-13 6:37 ` [RFC/PATCH 2/8]: CGroup Files: Add a cgroup write_string control file method menage-hpIqsD4AKlfQT0dZR+AlfA
2008-05-13 6:37 ` menage
[not found] ` <20080513071522.301139000-B63HFAS8fGlSzHKm+aFRNNkmqwFzkYv6@public.gmane.org>
2008-05-13 20:07 ` Andrew Morton
2008-05-13 20:44 ` Matt Helsley
2008-05-13 20:07 ` Andrew Morton
[not found] ` <20080513130710.36bc65f7.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-05-13 21:01 ` Paul Menage
2008-05-13 21:01 ` Paul Menage
2008-05-13 20:44 ` Matt Helsley
2008-05-13 6:37 ` [RFC/PATCH 3/8]: CGroup Files: Move the release_agent file to use typed handlers menage
2008-05-13 20:08 ` Andrew Morton [this message]
[not found] ` <20080513130833.cc03caea.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-05-13 21:32 ` Paul Menage
2008-05-13 21:32 ` Paul Menage
[not found] ` <20080513071522.470099000-B63HFAS8fGlSzHKm+aFRNNkmqwFzkYv6@public.gmane.org>
2008-05-13 20:08 ` Andrew Morton
2008-05-13 6:37 ` menage-hpIqsD4AKlfQT0dZR+AlfA
2008-05-13 6:37 ` [RFC/PATCH 4/8]: CGroup Files: Move notify_on_release file to separate write handler menage-hpIqsD4AKlfQT0dZR+AlfA
2008-05-13 6:37 ` menage
2008-05-13 6:37 ` [RFC/PATCH 5/8]: CGroup Files: Turn attach_task_by_pid directly into a cgroup " menage-hpIqsD4AKlfQT0dZR+AlfA
2008-05-13 6:37 ` menage
2008-05-13 6:37 ` [RFC/PATCH 6/8]: CGroup Files: Remove cpuset_common_file_write() menage-hpIqsD4AKlfQT0dZR+AlfA
2008-05-13 6:37 ` menage
[not found] ` <20080513071522.984545000-B63HFAS8fGlSzHKm+aFRNNkmqwFzkYv6@public.gmane.org>
2008-05-13 20:11 ` Andrew Morton
2008-05-13 20:11 ` Andrew Morton
[not found] ` <20080513131134.8b1cefe2.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-05-13 21:27 ` Paul Menage
2008-05-13 21:27 ` Paul Menage
2008-05-13 6:37 ` [RFC/PATCH 7/8]: CGroup Files: Convert devcgroup_access_write() into a cgroup write_string() handler menage-hpIqsD4AKlfQT0dZR+AlfA
2008-05-13 6:37 ` menage
2008-05-13 6:37 ` [RFC/PATCH 8/8]: CGroup Files: Convert res_counter_write() to be a cgroups " menage-hpIqsD4AKlfQT0dZR+AlfA
2008-05-13 6:37 ` menage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080513130833.cc03caea.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=balbir@in.ibm.com \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
--cc=pj@sgi.com \
--cc=serue@us.ibm.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.