From: Andrew Morton <akpm@linux-foundation.org>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>, linux-mips@linux-mips.org
Subject: Re: [PATCH RESEND] [MIPS]: multi-statement if() seems to be missing braces
Date: Tue, 13 May 2008 18:02:25 -0700 [thread overview]
Message-ID: <20080513180225.194f400b.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080513232507.GA24102@linux-mips.org>
On Wed, 14 May 2008 00:25:07 +0100 Ralf Baechle <ralf@linux-mips.org> wrote:
> On Tue, May 13, 2008 at 02:50:50PM +0300, Ilpo J__rvinen wrote:
>
> > In case this is a genuine bug, somebody else more familiar
> > with that stuff should evaluate it's effects (I just found it
> > by some shell pipeline and it seems suspicious looking).
>
> Should be fairly as proven by practice; it's there since day of of 64-bit
> pagetable for 32-bit hw support which was November 29, 2004.
>
It's unlikely that anyone would notice an error in pte_mkyoung(). It
will affect page reclaim behaviour and _might_ be demonstrable with a
carefully set up test. But an error in here won't cause crashes or
lockups or anything.
What this needs is someone who understands the architecture (ie: you
;)) to take a look, please.
next prev parent reply other threads:[~2008-05-14 1:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-13 11:50 [PATCH RESEND] [MIPS]: multi-statement if() seems to be missing braces Ilpo Järvinen
2008-05-13 23:25 ` Ralf Baechle
2008-05-14 1:02 ` Andrew Morton [this message]
2008-05-14 15:08 ` Ralf Baechle
2008-05-14 15:58 ` Enabling JFFS as Root FS Ramgopal Kota
2008-05-14 18:26 ` Problem with binutils Anoop P.A.
2008-05-14 18:26 ` Anoop P.A.
2008-05-15 13:57 ` Problem with MIPS cross toolchain Anoop P.A.
2008-05-15 13:57 ` Anoop P.A.
2008-05-15 7:21 ` Enabling JFFS as Root FS Freddy Spierenburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080513180225.194f400b.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.