From: Jack Steiner <steiner@sgi.com>
To: Nick Piggin <npiggin@suse.de>
Cc: Robin Holt <holt@sgi.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [patch 2/2] mm: remove nopfn
Date: Tue, 13 May 2008 20:22:45 -0500 [thread overview]
Message-ID: <20080514012245.GA6109@sgi.com> (raw)
In-Reply-To: <20080514004456.GB24516@wotan.suse.de>
On Wed, May 14, 2008 at 02:44:56AM +0200, Nick Piggin wrote:
> On Tue, May 13, 2008 at 11:20:46AM -0500, Jack Steiner wrote:
> > On Tue, May 13, 2008 at 10:48:12AM -0500, Jack Steiner wrote:
> > > On Tue, May 13, 2008 at 09:48:29AM +0200, Nick Piggin wrote:
> > > > There are no users of nopfn in the tree. Remove it.
> > > >
> > >
> > > The SGI mspec driver use to use the nopfn callout. I see that this
> > > was recently changed but the new code fails with:
> >
> > Wait.... Looks like I missed the patch that deleted the BUG_ON. That should
> > fix the problem (or at least change it).
> >
> > Retesting.....
>
> Thanks Jack, that would be a great help. Sorry, I should have cc'ed you
> on the first patch as well so that it would be more clear that you have to
> remove the BUG_ON.
>
No problem. I retested with the _correct_ patches. AFAICT, everything
works fine. Both mspec & GRU.
Should have dug deeper thru the mail lists....
--- jack
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2008-05-14 1:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-13 7:47 [patch 1/2] spufs: convert nopfn to fault Nick Piggin
2008-05-13 7:48 ` [patch 2/2] mm: remove nopfn Nick Piggin
2008-05-13 15:48 ` Jack Steiner
[not found] ` <20080513162046.GA22407@sgi.com>
2008-05-14 0:44 ` Nick Piggin
2008-05-14 1:22 ` Jack Steiner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080514012245.GA6109@sgi.com \
--to=steiner@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=holt@sgi.com \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.