All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>, fubar@us.ibm.com
Cc: netdev@vger.kernel.org, bonding-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] bonding: handle case of device named bonding_master
Date: Wed, 14 May 2008 18:15:28 -0700	[thread overview]
Message-ID: <20080514181528.1ff1791a@extreme> (raw)
In-Reply-To: <20080514181257.74fbb5aa@extreme>

If device already exists named bonding_masters, then fail. This is a wierd
corner case only a QA group could love.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
---
Note: bonding is not yet network namespace aware, it will need lots of
work to get this to happen.

--- a/drivers/net/bonding/bond_sysfs.c	2008-05-14 17:49:29.000000000 -0700
+++ b/drivers/net/bonding/bond_sysfs.c	2008-05-14 18:02:36.000000000 -0700
@@ -1437,8 +1437,16 @@ int bond_create_sysfs(void)
 	 * configure multiple bonding devices.
 	 */
 	if (ret == -EEXIST) {
-		netdev_class = NULL;
-		return 0;
+		/* Is someone being kinky and naming a device bonding_master? */
+		if (__dev_get_by_name(&init_net,
+				      class_attr_bonding_masters.attr.name))
+			printk(KERN_ERR
+			       "network device named %s already exists in sysfs",
+			       class_attr_bonding_masters.attr.name);
+		else {
+			netdev_class = NULL;
+			return 0;
+		}
 	}
 
 	return ret;

  parent reply	other threads:[~2008-05-15  1:16 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-15  0:03 [PATCH] net: Avoid problems with bonding and device rename Stephen Hemminger
2008-05-15  0:07 ` David Miller
2008-05-15  1:15 ` [PATCH 1/3] net: handle errors from device_rename Stephen Hemminger
2008-05-15  5:33   ` David Miller
2008-05-15  8:41   ` Wang Chen
2008-05-15 20:09     ` Stephen Hemminger
     [not found] ` <20080514181257.74fbb5aa@extreme>
2008-05-15  1:15   ` Stephen Hemminger [this message]
2008-05-15  5:35     ` [PATCH 3/3] bonding: handle case of device named bonding_master David Miller
2008-05-15  1:16   ` [PATCH 2/3] sysfs: remove error messages for -EEXIST case Stephen Hemminger
2008-05-15  1:26     ` David Miller
2008-05-15  3:14       ` Greg KH
2008-05-15  5:26         ` David Miller
2008-05-15  5:34     ` David Miller
2008-05-15  7:52     ` Cornelia Huck
2008-05-15  8:01       ` David Miller
2008-05-15  9:31         ` Cornelia Huck
2008-05-15 10:00           ` David Miller
2008-05-15 10:06             ` Cornelia Huck
2008-05-20 10:59               ` [PATCH] driver core: Suppress sysfs warnings for device_rename() Cornelia Huck
2008-05-20 21:45                 ` Stephen Hemminger
2008-05-20 22:52                   ` Greg KH
2008-05-20 22:52                 ` Greg KH
2008-05-21  8:05                   ` Cornelia Huck
2008-06-10  9:09                     ` Cornelia Huck
2008-06-10 15:30                       ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080514181528.1ff1791a@extreme \
    --to=shemminger@vyatta.com \
    --cc=bonding-devel@lists.sourceforge.net \
    --cc=davem@davemloft.net \
    --cc=fubar@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.