From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1760055AbYEOAAt@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1760055AbYEOAAt (ORCPT <rfc822;w@1wt.eu>);
	Wed, 14 May 2008 20:00:49 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756492AbYEOAAj
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Wed, 14 May 2008 20:00:39 -0400
Received: from ogre.sisk.pl ([217.79.144.158]:60600 "EHLO ogre.sisk.pl"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1757028AbYEOAAh (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 14 May 2008 20:00:37 -0400
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: BUG: sleeping function called from invalid context when hibernating
Date: Thu, 15 May 2008 02:00:46 +0200
User-Agent: KMail/1.9.6 (enterprise 20070904.708012)
Cc: sitsofe@yahoo.com, linux-kernel@vger.kernel.org, mingo@elte.hu,
       pavel@ucw.cz, a.p.zijlstra@chello.nl, jbarnes@virtuousgeek.org
References: <g0fnt2$5cr$1@ger.gmane.org> <200805150027.53217.rjw@sisk.pl> <20080514155244.c064559f.akpm@linux-foundation.org>
In-Reply-To: <20080514155244.c064559f.akpm@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200805150200.47397.rjw@sisk.pl>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thursday, 15 of May 2008, Andrew Morton wrote:
> On Thu, 15 May 2008 00:27:52 +0200
> "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> 
> > On Thursday, 15 of May 2008, Sitsofe Wheeler wrote:
> > > When using the linux-next kernel from 13 May 2008 I see the following in 
> > > the logs when resuming from hibernate (system is Ubuntu 7.10):
> > 
> > Something in the PCI department attempted to take a lock with interrupts
> > disabled, but that lock had previously been held with interrupts enabled, or so
> > it seems.  That something was called from pci_device_resume_early and it was
> > a VIA quirk, AFAICS.
> > 
> > I always need some help from people who actually understand these messages,
> > though.  Oh, well.
> > 
> > > [ 3283.928033] BUG: sleeping function called from invalid context at kernel/rwsem.c:21
> > > [ 3283.928033] in_atomic():0, irqs_disabled():1
> > > [ 3283.928033] 3 locks held by hibernate.sh/5892:
> > > [ 3283.928033]  #0:  (&buffer->mutex){--..}, at: [<c01958e3>] sysfs_write_file+0x25/0xdf
> > > [ 3283.928033]  #1:  (pm_mutex){--..}, at: [<c013d6c1>] hibernate+0x10/0x177
> > > [ 3283.928033]  #2:  (pm_sleep_rwsem){--..}, at: [<c021c32f>] device_suspend+0x2a/0x1c7
> > > [ 3283.928033] irq event stamp: 461790
> > > [ 3283.928033] hardirqs last  enabled at (461789): [<c0298283>] __mutex_unlock_slowpath+0xd6/0xde
> > > [ 3283.928033] hardirqs last disabled at (461790): [<c013d5fa>] hibernation_snapshot+0xab/0x162
> > > [ 3283.928033] softirqs last  enabled at (461166): [<c011e1de>] __do_softirq+0x8f/0x94
> > > [ 3283.928033] softirqs last disabled at (461161): [<c011e20d>] do_softirq+0x2a/0x42
> > > [ 3283.928033] Pid: 5892, comm: hibernate.sh Not tainted 2.6.25skw #25
> > > [ 3283.928033]  [<c0114aad>] __might_sleep+0xb8/0xbf
> > > [ 3283.928033]  [<c0298835>] down_read+0x19/0x68
> > > [ 3283.928033]  [<c01c5152>] pci_get_subsys+0x48/0xc5
> > > [ 3283.928033]  [<c01c51dd>] pci_get_device+0xe/0x10
> > > [ 3283.928033]  [<c01c41eb>] quirk_vialatency+0x1b/0xac
> > > [ 3283.928033]  [<c01c3fe0>] pci_fixup_device+0x70/0x7c
> > > [ 3283.928033]  [<c01c4ae5>] pci_device_resume_early+0x17/0x2e
> > > [ 3283.928033]  [<c021c154>] dpm_power_up+0x66/0x94
> > > [ 3283.928033]  [<c021c4d9>] device_power_up+0xd/0xf
> > > [ 3283.928033]  [<c013d66f>] hibernation_snapshot+0x120/0x162
> > > [ 3283.928033]  [<c013d771>] hibernate+0xc0/0x177
> > > [ 3283.928033]  [<c013c5ce>] ? state_store+0x0/0xaa
> > > [ 3283.928033]  [<c013c613>] state_store+0x45/0xaa
> > > [ 3283.928033]  [<c013c5ce>] ? state_store+0x0/0xaa
> > > [ 3283.928033]  [<c01b0c3d>] kobj_attr_store+0x1a/0x22
> > > [ 3283.928033]  [<c019596b>] sysfs_write_file+0xad/0xdf
> > > [ 3283.928033]  [<c01958be>] ? sysfs_write_file+0x0/0xdf
> > > [ 3283.928033]  [<c0164afd>] vfs_write+0x88/0xf8
> > > [ 3283.928033]  [<c0164f76>] sys_write+0x3b/0x60
> > > [ 3283.928033]  [<c01047a2>] sysenter_past_esp+0x5f/0xa5
> > > [ 3283.928033]  =======================
> > > [ 3283.928033] pci 0000:00:07.0: Disabling VIA external APIC routing
> > > 
> 
> That's the device_power_up() "Must be called with interrupts disabled"
> thing.
> 
> We break it again and again.

Well, in this particular case someone placed the quirk in the wrong place,
it shouldn't be called from pci_device_resume_early().

I'll have a closer look at it tomorrow.