From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Zhang Rui <rui.zhang@intel.com>
Cc: linux-acpi <linux-acpi@vger.kernel.org>, Len Brown <lenb@kernel.org>
Subject: Re: [PATCH 2/2] Add a passive cooling trip point if the firmware doesn't define one
Date: Thu, 15 May 2008 03:24:31 +0100 [thread overview]
Message-ID: <20080515022431.GA15085@srcf.ucam.org> (raw)
In-Reply-To: <1210817739.2929.24.camel@rzhang-crestline.sh.intel.com>
On Thu, May 15, 2008 at 10:15:39AM +0800, Zhang Rui wrote:
> On Thu, 2008-05-15 at 02:58 +0100, Matthew Garrett wrote:
> > I'll modify my patch so it uses the devices in a _TZD package if they're
> > present.
> >
> Hmm, ACPI thermal zone doesn't know how to throttle the devices in a
> _TZD package, so I don't think we can use the _TZD devices.
If they have a _TZD, it's presumably because they need cooling. If the
kernel isn't going to be able to do that, what happens if the userspace
daemon crashes or fails to start for some reason?
The alternative is to leave it as it is currently in my patch. If the
userspace daemon starts, it disables the ACPI control and will handle it
itself. If it doesn't start, the kernel does the only thing it can -
reduce the speed of the CPU. If there are no plans to add hooks for the
drivers to be throttled by the kernel, then I'd argue that this is the
right thing to do.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2008-05-15 2:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 1:00 [PATCH] Fix polling policy in the absence of _TZP Matthew Garrett
2008-05-14 1:03 ` [PATCH 1/2] Add a list of processor objects to the ACPI core Matthew Garrett
2008-05-14 1:08 ` [PATCH 2/2] Add a passive cooling trip point if the firmware doesn't define one Matthew Garrett
2008-05-14 3:30 ` Len Brown
2008-05-14 9:33 ` Matthew Garrett
2008-05-14 15:37 ` Len Brown
2008-05-14 23:01 ` Matthew Garrett
2008-05-15 0:55 ` Zhang Rui
2008-05-15 1:04 ` Matthew Garrett
[not found] ` <1210814699.2929.10.camel@rzhang-crestline.sh.intel.com>
[not found] ` <20080515015831.GA14829@srcf.ucam.org>
2008-05-15 2:15 ` Zhang Rui
2008-05-15 2:24 ` Matthew Garrett [this message]
2008-05-15 3:06 ` Zhang Rui
2008-05-15 11:40 ` Matthew Garrett
2008-05-15 11:47 ` Andi Kleen
2008-05-15 12:02 ` Matthew Garrett
2008-05-14 3:19 ` [PATCH] Fix polling policy in the absence of _TZP Len Brown
2008-05-14 10:14 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080515022431.GA15085@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.