From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: fix entry-common.S
Date: Thu, 15 May 2008 04:26:28 +0000 [thread overview]
Message-ID: <20080515042628.GA2260@linux-sh.org> (raw)
In-Reply-To: <20080514.110900.125129265.saito@densan.co.jp>
On Wed, May 14, 2008 at 11:09:00AM +0900, Hideo Saito wrote:
> In the code on entry-common.S, it seems that the following fix is
> needed, because the code causes to jump to |resume_userspace| from
> |syscall_badsys| without set r8.
>
That's true for the syscall_badsys path, but not for any of the other
resume_userspace callees. The comment at the beginning of
resume_userspace indicates that we expect r8 to be set by the caller,
which looks like it got trampled in the syscall_badsys case. So, I've
moved the r8 assignment in to the syscall_badsys path instead.
Good catch, thanks!
prev parent reply other threads:[~2008-05-15 4:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 2:09 fix entry-common.S Hideo Saito
2008-05-15 4:26 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080515042628.GA2260@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.