Re: [PATCH V4] I2C bus driver for IMX

[Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1154 bytes --]

On Thu, May 15, 2008 at 10:55:30AM +0300, Darius wrote:

> >> +	for (i=0; i<I2C_IMX_TIME_BUSY; i++) {
> > spacing in here: for (i = 0; i < I2C_IMX_TIME_BUSY; i++)
> what is there wrong with spacing?
>
> > spacing in here, (temp & I2CR_IEN) ? 1 : 0
> I really should add dummy spaces...?
Please do. Documentation/CodingStyle recommends it. While personal
opinions on ceratin topics may vary, I think it is indeed helpful,
if all kernel sources look somewhat similar.

> > yeurk, put these in a seperate header file, or place them near
> > the driver. The "One Big Register File" is horrible, and hopefully
> seems, everybody has her own opinion. Is there somebody one, who can say
> how that should be? Because I have already two times changed that... I'm
> only beginner, so ambiguous comments are very unwanted...  As I know,
> Jean Delvare is responsible for I2C drivers. So, his word is welcome:)
He suggested the same (= no register file) to me in January for the
PCA9564-driver.

All the best,

   Wolfram

-- 
  Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c