All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <me@felipebalbi.com>
Cc: andrzej zaborowski <balrogg@gmail.com>,
	linux-omap@vger.kernel.org, daniel.stone@nokia.com
Subject: Re: [PATCH 2/2] Input: Make lm8323 sticky key to work with console
Date: Thu, 15 May 2008 01:31:44 -0700	[thread overview]
Message-ID: <20080515083144.GN8928@atomide.com> (raw)
In-Reply-To: <20080515082957.GM8928@atomide.com>

* Tony Lindgren <tony@atomide.com> [080515 01:30]:
> * Felipe Balbi <me@felipebalbi.com> [080515 01:19]:
> > On Thu, May 15, 2008 at 10:14:24AM +0200, andrzej zaborowski wrote:
> > > On 15/05/2008, Felipe Balbi <me@felipebalbi.com> wrote:
> > > > On Wed, May 14, 2008 at 09:01:19PM -0700, Tony Lindgren wrote:
> > > >  > This allows using N810 keyboard from console by adding optional
> > > >  > Fn and shift sticky key handling by passing them from platform_data.
> > > >  >
> > > >  > Currently some not so obvious mappings are:
> > > >  >
> > > >  > - Pipe is Fn + Enter
> > > >  > - Delete is Fn + Backspace
> > > >  > - Escape is Fn + Ctrl
> > > >
> > > >  no tab? :-(
> > > >
> > > >  Fn + space maybe?? :-p
> > > 
> > > Fn + Right is assigned in the patch (I check too :) ).  But I'm not
> > > sure whther that should be done in the lm8323 driver or elsewhere. The
> > > existence of keys like Fn and Shift is N810-specific and lm8323 is
> > > just a gpio matrix keypad chip.
> > 
> > but that's coming from board file. It should be ok.
> 
> Yeah I think it should be OK too as nothing happens if platform_data does
> not pass fn or shift keys. So the driver should work with any keyboard
> layout.

BTW, I like the idea for FN + space for tab key, easier to use than
FN + Right :)

Tony

  reply	other threads:[~2008-05-15  8:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-15  4:01 [PATCH 0/2] Make N810 keyboard work with console Tony Lindgren
2008-05-15  4:01 ` [PATCH 1/2] Input: Fix lm8323 probe and module unloading Tony Lindgren
2008-05-15  4:01   ` [PATCH 2/2] Input: Make lm8323 sticky key to work with console Tony Lindgren
2008-05-15  8:03     ` Felipe Balbi
2008-05-15  8:14       ` andrzej zaborowski
2008-05-15  8:20         ` Felipe Balbi
2008-05-15  8:29           ` Tony Lindgren
2008-05-15  8:31             ` Tony Lindgren [this message]
2008-05-15  8:01   ` [PATCH 1/2] Input: Fix lm8323 probe and module unloading Felipe Balbi
2008-05-15 18:18     ` [PATCH 1/2] Input: Fix lm8323 probe and module unloading, take #2 Tony Lindgren
2008-05-15 22:54       ` Tony Lindgren
2008-05-15  8:58 ` [PATCH 0/2] Make N810 keyboard work with console Daniel Stone
2008-05-15 17:22   ` Tony Lindgren
2008-05-15 18:19     ` [PATCH 0/2] Make N810 keyboard work with console, take #2 Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080515083144.GN8928@atomide.com \
    --to=tony@atomide.com \
    --cc=balrogg@gmail.com \
    --cc=daniel.stone@nokia.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=me@felipebalbi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.