All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarek Poplawski <jarkao2@gmail.com>
To: Patrick McHardy <kaber@trash.net>
Cc: Kingsley Foreman <kingsley@internode.com.au>,
	Eric Dumazet <dada1@cosmosbay.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: NET_SCHED cbq dropping too many packets on a bonding interface
Date: Thu, 15 May 2008 20:09:14 +0200	[thread overview]
Message-ID: <20080515180914.GA2936@ami.dom.local> (raw)
In-Reply-To: <482C6040.9030808@trash.net>

On Thu, May 15, 2008 at 06:09:36PM +0200, Patrick McHardy wrote:
> Kingsley Foreman wrote:
>> i just rolled back the kernel to 2.6.24 and im seeing the same thing,
>>
>> I was using 2.6.22 before and didn't see the problem, txqueuelen on the 
>> bond0 interface is 0 (the default)
>
> That might explain things, although it shouldn't have worked before
> either.
>
> CBQ creates default pfifo qdiscs for its leaves, these use a limit
> of txqueuelen or 1 if it is zero. So even small bursts will cause
> drops. Do things improve if you set txqueuelen to a larger value
> *before* configuring the qdiscs?

Kingsley wrote to me that even after changing txqueuelen to 1000 the
"dropped" number didn't change much. A debugging patch with printks
around all "sch->qstats.dropps++" showed only the end of cbq_enqueue().
I've asked to check tomorrow "pfifo limit 1000" for these drops too.

> Another thing is that CBQ on bond will probably not work properly
> at all, it needs a real device since it measures the timing between
> dequeue events for idle time estimation. On software devices this
> doesn't work.

Right, but these drops without any sign of overactions or overlimits
seem to show it's not about shaping (or it's not counted/documented
enough).

Regards,
Jarek P.

  reply	other threads:[~2008-05-15 18:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-15  2:55 NET_SCHED cbq dropping too many packets on a bonding interface Kingsley Foreman
2008-05-15  3:56 ` Andrew Morton
2008-05-15  5:21   ` Eric Dumazet
2008-05-15  6:16     ` Kingsley Foreman
2008-05-15  9:12       ` Jarek Poplawski
2008-05-15 10:06         ` Kingsley Foreman
2008-05-15 10:29           ` Jarek Poplawski
2008-05-15 15:59           ` Patrick McHardy
2008-05-15 16:09           ` Patrick McHardy
2008-05-15 18:09             ` Jarek Poplawski [this message]
2008-05-15 18:14               ` Patrick McHardy
2008-05-15 18:25             ` Jarek Poplawski
2008-05-15 18:32               ` Patrick McHardy
2008-05-15 18:46                 ` Jarek Poplawski
2008-05-15 21:27                   ` Kingsley Foreman
2008-05-16  5:49                     ` Jarek Poplawski
2008-05-16  6:12                       ` Kingsley Foreman
2008-05-16  7:01                         ` Jarek Poplawski
2008-05-16  7:22                           ` Jarek Poplawski
2008-05-16 11:56                             ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080515180914.GA2936@ami.dom.local \
    --to=jarkao2@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=dada1@cosmosbay.com \
    --cc=kaber@trash.net \
    --cc=kingsley@internode.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.