All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
	ajones@riverbed.com, a.p.zijlstra@chello.nl, mszeredi@suse.cz,
	akpm@linux-foundation.org, kay.sievers@vrfy.org,
	trond.myklebust@fys.uio.no, linux-kernel@vger.kernel.org
Subject: Re: [BUG] mm: bdi: export BDI attributes in sysfs
Date: Thu, 15 May 2008 13:40:59 -0700	[thread overview]
Message-ID: <20080515204059.GA19417@kroah.com> (raw)
In-Reply-To: <alpine.LFD.1.10.0805151247010.3019@woody.linux-foundation.org>

On Thu, May 15, 2008 at 12:54:57PM -0700, Linus Torvalds wrote:
> 
> 
> On Thu, 15 May 2008, Miklos Szeredi wrote:
> > 
> > Actually nothing should need protection.  The only problem AFAICS is
> > that the device_create()/dev_set_drvdata() interface is racy: somebody
> > can come in after the device has been created but before drvdata has
> > been set, and then we are in trouble.
> 
> Well, I'm not sure that the locking should be at that level. Maybe the 
> locking *should* be in the driver that does this. It may need to do other 
> setup too, after all.
> 
> Of course, doing a device_create_drvdata() thing might be the right 
> solution, at least part of the time. Greg?

Yes, you are right, let me go knock that together...

thanks,

greg k-h

  reply	other threads:[~2008-05-15 20:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080513190435.GG23649@ajones-laptop.nbttech.com>
2008-05-14 14:40 ` [BUG] mm: bdi: export BDI attributes in sysfs Arthur Jones
2008-05-15 18:53   ` Miklos Szeredi
2008-05-15 19:18     ` Linus Torvalds
2008-05-15 19:27       ` Miklos Szeredi
2008-05-15 19:54         ` Linus Torvalds
2008-05-15 20:40           ` Greg KH [this message]
2008-05-15 21:02           ` Greg KH
2008-05-15 22:05             ` Arthur Jones
2008-05-15 23:20               ` Greg KH
2008-05-16  4:59               ` Greg KH
2008-05-15 20:37         ` Greg KH
2008-05-15 20:40           ` Greg KH
2008-05-15 20:44     ` Arthur Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080515204059.GA19417@kroah.com \
    --to=greg@kroah.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=ajones@riverbed.com \
    --cc=akpm@linux-foundation.org \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=mszeredi@suse.cz \
    --cc=torvalds@linux-foundation.org \
    --cc=trond.myklebust@fys.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.