Re: [PATCH] tridentfb: acceleration code improvements

[Andrew Morton <akpm@linux-foundation.org>]

On Fri, 16 May 2008 06:46:02 +0200 Krzysztof Helt <krzysztof.h1@poczta.fm> wrote:

> On Thu, 15 May 2008 15:56:14 -0700
> Andrew Morton <akpm@linux-foundation.org> wrote:
> 
> > On Wed, 14 May 2008 07:12:00 +0200
> > checkpatch whines:
> > 
> > ERROR: space required after that ',' (ctx:VxV)
> (...)
> 
> How do you run the checkpatch? I am not getting these warning even with the "--strict" option (stock linux-2.6.26-rc2 kernel scripts). Do you have another version?
> I'd like to have the same version as you.

doh.  -mm's update-checkpatchpl-to-version-019.patch is needed to pick
up this problem.

> > 
> > Also that macro is plain wrong:
> > 
> > 	if (foo)
> > 		debug(...);
> > 	else
> > 		something();
> > 
> > won't compile.  Using the do{...}while(0) thing or perhaps {(...)} will fix.
> > 
> I'll fix it.

Cool.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft 
Defy all challenges. Microsoft(R) Visual Studio 2008. 
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/