From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [patch 07/11] acpi_pm_device_sleep_state() cleanup Date: Fri, 16 May 2008 11:03:12 -0700 Message-ID: <200805161103.13871.jbarnes@virtuousgeek.org> References: <200805142309.m4EN9KBX025994@imap1.linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: Received: from outbound-mail-03.bluehost.com ([69.89.21.13]:36594 "HELO outbound-mail-03.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1759085AbYEPSKH (ORCPT ); Fri, 16 May 2008 14:10:07 -0400 In-Reply-To: <200805142309.m4EN9KBX025994@imap1.linux-foundation.org> Content-Disposition: inline Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: akpm@linux-foundation.org Cc: lenb@kernel.org, linux-acpi@vger.kernel.org, dbrownell@users.sourceforge.net, bjorn.helgaas@hp.com, pavel@ucw.cz, trenn@suse.de On Wednesday, May 14, 2008 4:09 pm akpm@linux-foundation.org wrote: > From: David Brownell > > Get rid of a superfluous acpi_pm_device_sleep_state() parameter. The only > legitimate value of that parameter must be derived from the first > parameter, which is what all the callers already do. (However, this does > not address the fact that ACPI *still* doesn't set up those flags.) > > Signed-off-by: David Brownell > Acked-by: Pavel Machek > Cc: Thomas Renninger > Cc: Len Brown > Cc: Jesse Barnes > Cc: Bjorn Helgaas > Signed-off-by: Andrew Morton Looks good to me, should probably go in through the ACPI tree. Acked-by: Jesse Barnes