From: Kyle McMartin <kyle@mcmartin.ca>
To: Paul Mundt <lethal@linux-sh.org>,
Andrew Morton <akpm@linux-foundation.org>,
hskinnemoen@atmel.com, nurhussein@gmail.com,
linux-kernel@vger.kernel.org, randy.dunlap@oracle.com,
arjan@infradead.org, mingo@elte.hu, a.p.zijlstra@chello.nl,
kyle@parisc-linux.org, schwidefsky@de.ibm.com
Subject: Re: [PATCH] lib: Taint kernel in common report_bug() WARN path.
Date: Fri, 16 May 2008 10:57:18 -0400 [thread overview]
Message-ID: <20080516145718.GD9666@phobos.i.cabal.ca> (raw)
In-Reply-To: <20080516052127.GB15431@linux-sh.org>
On Fri, May 16, 2008 at 02:21:27PM +0900, Paul Mundt wrote:
> Commit 95b570c9cef3b12356454c7112571b7e406b4b51 introduced a
> TAINT_WARN that was implemented for all architectures using the
> generic warn_on_slowpath(), which excluded any architecture that
> set HAVE_ARCH_WARN_ON.
>
> As all of the architectures that implement their own WARN_ON()
> all go through the report_bug() path (specifically handling
> BUG_TRAP_TYPE_WARN), taint the kernel there as well for consistency.
>
> Tested on avr32 and sh. Also relevant for s390, parisc, and powerpc.
>
> Signed-off-by: Haavard Skinnemoen <hskinnemoen@atmel.com>
> Signed-off-by: Paul Mundt <lethal@linux-sh.org>
>
obviously fine by me.
Acked-by: Kyle McMartin <kyle@mcmartin.ca>
prev parent reply other threads:[~2008-05-16 15:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-16 5:21 [PATCH] lib: Taint kernel in common report_bug() WARN path Paul Mundt
2008-05-16 14:57 ` Kyle McMartin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080516145718.GD9666@phobos.i.cabal.ca \
--to=kyle@mcmartin.ca \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=hskinnemoen@atmel.com \
--cc=kyle@parisc-linux.org \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nurhussein@gmail.com \
--cc=randy.dunlap@oracle.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.