Re: [PATCH net-next 1/6] [BNX2]: Allow phy reset to be skipped during chip reset.

[Andy Gospodarek <andy@greyhouse.net>]

On Fri, May 16, 2008 at 02:29:36PM -0700, Michael Chan wrote:
> [BNX2]: Allow phy reset to be skipped during chip reset.
> 
> Andy Gospodarek <andy@greyhouse.net> found that netconsole would
> panic when resetting bnx2 devices.
> 
> >From Andy:
> "The issue is the bnx2_set_link in bnx2_init_nic will print a link-status
> message before we are fully initialized and ready to start polling.
> Polling is currently disabled in this state, but since the
> __LINK_STATE_RX_SCHED is overloaded to not only try and disable polling
> but also to make the system aware there is something waiting to be
> polled, we really have to fix this in drivers.
> 
> The problematic call is the one to netif_rx_complete as it tries to
> remove an entry from the poll_list when there isn't one."
> 
> While this netconsole problem should be fixed separately, we really
> should not reset the PHY when changing ring sizes, MTU, or other
> similar settings.  The PHY reset causes several seconds of unnecessary
> link disruptions.
> 
> Signed-off-by: Michael Chan <mchan@broadcom.com>
> Cc: Andy Gospodarek <andy@greyhouse.net>

Acked-by: Andy Gospodarek <andy@greyhouse.net>