From: "Stephen R. van den Berg" <srb@cuci.nl>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Avery Pennarun <apenwarr@gmail.com>,
Tommy Thorn <tommy-git@thorn.ws>,
git@vger.kernel.org
Subject: Re: [PATCH] mailsplit and mailinfo: gracefully handle NUL characters
Date: Sat, 17 May 2008 12:07:26 +0200 [thread overview]
Message-ID: <20080517100726.GA24416@cuci.nl> (raw)
In-Reply-To: <alpine.DEB.1.00.0805170058160.30431@racer>
Johannes Schindelin wrote:
>On Fri, 16 May 2008, Avery Pennarun wrote:
>> fread is about 18x faster than fgetc(). getc() is the same speed as
>> fgetc(). getc_unlocked() is definitely faster than getc, but still at
>> least 7x slower than fread().
>Well, my question was more about fgetc() vs fgets().
>If you feel like it, you might benchmark this patch:
Wouldn't it be better to improve the implementation of getc()
in glibc instead?
getc() is meant to be the fast version of fgetc(), and if it isn't
(anymore), then the library needs fixing.
--
Sincerely, srb@cuci.nl
Stephen R. van den Berg.
next prev parent reply other threads:[~2008-05-17 10:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 7:27 git bug: rebase fatal failure Tommy Thorn
2008-05-16 10:41 ` Johannes Schindelin
2008-05-16 11:01 ` Johannes Schindelin
2008-05-16 13:03 ` [PATCH] mailsplit and mailinfo: gracefully handle NUL characters Johannes Schindelin
2008-05-16 14:03 ` Avery Pennarun
2008-05-16 14:05 ` David Kastrup
2008-05-16 14:32 ` Johannes Schindelin
2008-05-16 14:56 ` Avery Pennarun
2008-05-16 23:59 ` Johannes Schindelin
2008-05-17 0:06 ` Tommy Thorn
2008-05-17 0:26 ` Johannes Schindelin
2008-05-17 10:07 ` Stephen R. van den Berg [this message]
2008-05-17 10:18 ` Johannes Schindelin
[not found] ` <200805161539.29259.brian.foster@innova-card.com>
2008-05-16 14:07 ` Brian Foster
2008-05-16 14:14 ` David Kastrup
2008-05-16 14:29 ` Johannes Schindelin
2008-05-16 14:33 ` David Kastrup
2008-05-21 18:08 ` Junio C Hamano
2008-05-22 10:38 ` Johannes Schindelin
2008-05-22 17:44 ` Junio C Hamano
2008-05-23 11:21 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080517100726.GA24416@cuci.nl \
--to=srb@cuci.nl \
--cc=Johannes.Schindelin@gmx.de \
--cc=apenwarr@gmail.com \
--cc=git@vger.kernel.org \
--cc=tommy-git@thorn.ws \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.