From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1757491AbYEQPbV@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757491AbYEQPbV (ORCPT <rfc822;w@1wt.eu>);
	Sat, 17 May 2008 11:31:21 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754723AbYEQPbM
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Sat, 17 May 2008 11:31:12 -0400
Received: from x346.tv-sign.ru ([89.108.83.215]:53552 "EHLO mail.screens.ru"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754235AbYEQPbK (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sat, 17 May 2008 11:31:10 -0400
Date: Sat, 17 May 2008 19:31:40 +0400
From: Oleg Nesterov <oleg@tv-sign.ru>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Austin Clements <amdragon+kernelbugzilla@mit.edu>,
       Ingo Molnar <mingo@elte.hu>, john stultz <johnstul@us.ibm.com>,
       Linus Torvalds <torvalds@linux-foundation.org>,
       Michael Kerrisk <mtk.manpages@googlemail.com>,
       Roland McGrath <roland@redhat.com>,
       Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] posix timers: use SIGQUEUE_CANCELLED when the timer is destroyed
Message-ID: <20080517153140.GA9534@tv-sign.ru>
References: <20080517151422.GA9502@tv-sign.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080517151422.GA9502@tv-sign.ru>
User-Agent: Mutt/1.5.11
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/17, Oleg Nesterov wrote:
>
> This is a user visible change. With this patch sys_timer_delete() discards
> the pending signal which was generated by the timer.

If this change is undesirable, we can (for example) do

	--- kernel/posix-timers.c
	+++ kernel/posix-timers.c
	@@ -885,6 +885,7 @@ itimer_delete(struct k_itimer *timer)
		timer->it_process = NULL;
	 
		unlock_timer(timer, flags);
	+	tmr->sigq->flags |= SIGQUEUE_CANCELLED;
		release_posix_timer(timer, IT_ID_SET);
	 }

instead, and still fix the "BUG 10460".

Oleg.