From: Pierre Habouzit <madcoder@debian.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add color.diff.{header,message} formats
Date: Sat, 17 May 2008 20:34:19 +0200 [thread overview]
Message-ID: <20080517183419.GC16746@artemis.madism.org> (raw)
In-Reply-To: <7vej80dcdc.fsf@gitster.siamese.dyndns.org>
[-- Attachment #1: Type: text/plain, Size: 1372 bytes --]
On Sat, May 17, 2008 at 06:17:03PM +0000, Junio C Hamano wrote:
> Pierre Habouzit <madcoder@debian.org> writes:
>
> > Hmmm it seems this patch has been somehow lost somewhere, is there
> > anything wrong with it ?
>
> It may not break anything, and I did not hear anybody on the list who said
> this breaks soemthing. But I did not hear anybody on the list who wanted
> to have this except you, either. At this stage of development, the
> question we should be asking is not if there is anything wrong with it,
> but if there is anything _good_ with it.
Well the thing is that I (and the few people that made me write the
patch) find git log -p hard to read, because my eyes tend to not see the
separations between two commits. Having a different color for commit
messages help a lot.
> It looks rather widespread compared to a perceived benefit. Perhaps after
> a refactoring to make the parameter to pretty-print-commit a bit more
> easily extensible, the patch might start looking more promising. I dunno.
Fair enough, I wrote the patch for others, I use it on my git, but I'm
not really into doing that amount of work to push it in git.git either …
--
·O· Pierre Habouzit
··O madcoder@debian.org
OOO http://www.madism.org
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2008-05-17 18:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-05 9:38 [PATCH] Add color.diff.{header,message} formats Pierre Habouzit
2008-05-17 13:07 ` Pierre Habouzit
2008-05-17 18:17 ` Junio C Hamano
2008-05-17 18:34 ` Pierre Habouzit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080517183419.GC16746@artemis.madism.org \
--to=madcoder@debian.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.