All of lore.kernel.org
 help / color / mirror / Atom feed
From: Muli Ben-Yehuda <muli@il.ibm.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
	akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC: 2.6 patch] remove the OSS trident driver
Date: Sun, 18 May 2008 09:45:51 +0300	[thread overview]
Message-ID: <20080518064551.GD7421@il.ibm.com> (raw)
In-Reply-To: <20080516002355.GM1936@cs181133002.pp.htv.fi>

On Fri, May 16, 2008 at 03:23:55AM +0300, Adrian Bunk wrote:
> On Wed, May 14, 2008 at 08:47:08AM +0300, Muli Ben-Yehuda wrote:
> >...
> > Also, I no longer have working trident hardware---if someone else does
> > and can test this, please let me know. Otherwise we can should
> > probably go ahead and remove this old OSS driver.
> 
> Considering that we have a working ALSA driver for this hardware, and 
> your past objections against the removal were the sole reason why this 
> is the only PCI OSS driver we still have in the tree, I'd actually 
> prefer doing this (patch below).
> 
> Is this OK for you?

Yep. Please also add to the patch the CREDITS snippet below.

> SOUND_TRIDENT was the last PCI OSS driver, and since there's already an 
> ALSA driver for the same hardware we can remove it.
> 
> Signed-off-by: Adrian Bunk <bunk@kernel.org>

Signed-off-by: Muli Ben-Yehuda <muli@il.ibm.com>

diff --git a/CREDITS b/CREDITS
index 8fec7b3..2259308 100644
--- a/CREDITS
+++ b/CREDITS
@@ -317,6 +317,14 @@ S: 2322 37th Ave SW
 S: Seattle, Washington 98126-2010
 S: USA
 
+N: Muli Ben-Yehuda
+E: mulix@mulix.org
+E: muli@il.ibm.com
+W: http://www.mulix.org
+D: trident OSS sound driver, x86-64 dma-ops and Calgary IOMMU,
+D: KVM and Xen bits and other misc. hackery.
+S: Haifa, Israel
+
 N: Johannes Berg
 E: johannes@sipsolutions.net
 W: http://johannes.sipsolutions.net/

      reply	other threads:[~2008-05-18  6:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-13 21:05 [PATCH] OSS trident: switch from ->write_proc Alexey Dobriyan
2008-05-14  5:47 ` Muli Ben-Yehuda
2008-05-14 20:49   ` Alexey Dobriyan
2008-05-15 16:48     ` Muli Ben-Yehuda
2008-05-16  0:23   ` [RFC: 2.6 patch] remove the OSS trident driver Adrian Bunk
2008-05-18  6:45     ` Muli Ben-Yehuda [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080518064551.GD7421@il.ibm.com \
    --to=muli@il.ibm.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@osdl.org \
    --cc=bunk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.