All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	"Maciej W. Rozycki" <macro@linux-mips.org>,
	Tom Spink <tspink@gmail.com>, Ingo Molnar <mingo@elte.hu>,
	"H. Peter Anvin" <hpa@zytor.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Jiri Slaby <jirislaby@gmail.com>, Sam Ravnborg <sam@ravnborg.org>,
	Andi Kleen <andi@firstfloor.org>
Subject: Re: [RFC] x86: merge nmi_32-64 to nmi.c
Date: Sun, 18 May 2008 11:38:04 +0400	[thread overview]
Message-ID: <20080518073804.GB6948@cvg> (raw)
In-Reply-To: <482FD9F2.8080204@goop.org>

[Jeremy Fitzhardinge - Sun, May 18, 2008 at 08:25:38AM +0100]
> Thomas Gleixner wrote:
>> Definitely, but we should do it at the Kconfig level which allows us
>> to have integer defines as well, so we end up with something like:
>>
>> static inline unsigned int get_nmi_count(int cpu)
>> {
>>       return CONFIG_X86_64 ? cpu_pda(cpu)->__nmi_count : nmi_count(cpu);
>> }
>>   
>
> Unfortunately that doesn't work because when CONFIG_X86_64 isn't defined it 
> doesn't expand to 0.  It would be nice if CONFIG_* expanded to 0/1, but 
> we'd need to change all the #ifdef CONFIG_* to #if CONFIG_*...
>
>    J
>

I think I would prefer Maciej's advice then but with capital
letters (to easy distinguish them and point an attention) like

#ifdef CONFG_X86_64
#define CPU_64 1
#else
#define CPU_64 0
#endif

		- Cyrill -

  reply	other threads:[~2008-05-18  7:40 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-17 19:22 [RFC] x86: merge nmi_32-64 to nmi.c Cyrill Gorcunov
2008-05-17 20:28 ` Tom Spink
2008-05-17 20:52   ` Maciej W. Rozycki
2008-05-17 21:40     ` Thomas Gleixner
2008-05-18  7:25       ` Jeremy Fitzhardinge
2008-05-18  7:38         ` Cyrill Gorcunov [this message]
2008-05-18  8:33           ` Jeremy Fitzhardinge
2008-05-18  8:47             ` Cyrill Gorcunov
2008-05-18  9:13             ` Cyrill Gorcunov
2008-05-18  9:09         ` Thomas Gleixner
2008-05-18  9:35           ` Cyrill Gorcunov
2008-05-18 18:08         ` Adrian Bunk
2008-05-18 18:13           ` Andi Kleen
2008-05-18 18:35             ` Jeremy Fitzhardinge
2008-05-18 19:13               ` Andi Kleen
2008-05-19 14:27                 ` Cyrill Gorcunov
2008-05-18 18:33           ` Jeremy Fitzhardinge
2008-05-18 19:29             ` Adrian Bunk
2008-05-18 19:51               ` Jeremy Fitzhardinge
2008-05-18 18:38           ` Maciej W. Rozycki
2008-05-18 20:40             ` Adrian Bunk
2008-05-18 10:15       ` Andi Kleen
2008-05-18 10:20         ` Cyrill Gorcunov
2008-05-18 10:25           ` Andi Kleen
2008-05-18 10:29             ` Cyrill Gorcunov
2008-05-18 12:07               ` Tom Spink
2008-05-18 12:10                 ` Cyrill Gorcunov
2008-05-17 21:48     ` Mikael Pettersson
2008-05-17 22:34       ` Thomas Gleixner
2008-05-18  6:24         ` Cyrill Gorcunov
2008-05-18 10:04         ` Cyrill Gorcunov
2008-05-18 10:09         ` Cyrill Gorcunov
2008-05-19 18:07         ` Cyrill Gorcunov
2008-05-19 18:41           ` Cyrill Gorcunov
2008-05-21  7:41             ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080518073804.GB6948@cvg \
    --to=gorcunov@gmail.com \
    --cc=andi@firstfloor.org \
    --cc=hpa@zytor.com \
    --cc=jeremy@goop.org \
    --cc=jirislaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=macro@linux-mips.org \
    --cc=mingo@elte.hu \
    --cc=sam@ravnborg.org \
    --cc=tglx@linutronix.de \
    --cc=tspink@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.