Re: [PATCH 0/3] git-cvsserver: Add support for some binary files

[Matthew Ogilvie <mmogilvi_git@miniinfo.net>]

On Fri, May 16, 2008 at 05:03:40PM -0700, Junio C Hamano wrote:
> Matthew Ogilvie <mmogilvi_git@miniinfo.net> writes:
> 
> > This series of patches extends git-cvsserver to support telling the
> > CVS client to set the -kb (binary) mode for files that git considers
> > to be binary (and not for text files).  It includes updates to
> > documentation and tests.
> 
> I am unfortunately not familiar with this part of the system and I'd need
> to summon help from experts, but it looks rather nicely done.
> 
> I saw a few places that said "crnl" instead of "crlf" in the
> documentation, which I munged locally before queuing.

Sounds good.

> 
> I noticed kopts_from_path in patch 3/3 takes $srcType of "sha1Or-k" but I
> could not spot which caller gives such token to the function.

Oops.  The "sha1Or-k" cases can and probably should be removed
completely.

I can generate another patch if you would like.

It's a remnant of an approach I had been working on earlier,
when I thought there might be cases when I needed to fall back on
the -k option the user specified on the command line because I didn't
have the file contents.  But careful study revealed what I needed
elsewhere in the data structures.

--
Matthew Ogilvie   [mmogilvi_git@miniinfo.net]