From: Christoph Hellwig <hch@infradead.org>
To: Lachlan McIlroy <lachlan@sgi.com>
Cc: sgi.bugs.xfs@engr.sgi.com, xfs@oss.sgi.com
Subject: Re: TAKE 981875 - xfs_dm_rdwr() needs to pass a vfsmount to dentry_open()
Date: Tue, 20 May 2008 02:43:56 -0400 [thread overview]
Message-ID: <20080520064356.GA8711@infradead.org> (raw)
In-Reply-To: <20080516051048.GB5035@infradead.org>
On Fri, May 16, 2008 at 01:10:48AM -0400, Christoph Hellwig wrote:
> On Fri, May 16, 2008 at 02:57:32PM +1000, Lachlan McIlroy wrote:
> > xfs_dm_rdwr() needs to pass a vfsmount to dentry_open()
> >
> > We need a vfsmount pointer in xfs_dm_rdwr() but we are not
> > provided with one and there's no way to get to it. So add
> > a m_vfsmount field to the xfs_mount structure and set it
> > up at mount time. We can then access it through the xfs
> > inode.
>
> Stong NACK for this crap, and double NACK for pushing this towards
> mainline.
No reply yet. Folks, you realize this is an instant oops if you perform
dmapi operations after one fs instance has been unmounted?
next prev parent reply other threads:[~2008-05-20 6:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-16 4:57 TAKE 981875 - xfs_dm_rdwr() needs to pass a vfsmount to dentry_open() Lachlan McIlroy
2008-05-16 5:10 ` Christoph Hellwig
2008-05-20 6:43 ` Christoph Hellwig [this message]
2008-05-26 6:02 ` Niv Sardi
2008-07-26 16:30 ` Christoph Hellwig
2008-07-28 6:11 ` Niv Sardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080520064356.GA8711@infradead.org \
--to=hch@infradead.org \
--cc=lachlan@sgi.com \
--cc=sgi.bugs.xfs@engr.sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.