Re: [PATCH] Make

[Arjan van de Ven <arjan@infradead.org>]

On Tue, 20 May 2008 07:54:10 -0700 (PDT)
Linus Torvalds <torvalds@linux-foundation.org> wrote:

> 
> 
> On Tue, 20 May 2008, Dave Jones wrote:
> > 
> > Like this ?  (I don't have a -mm handy, so guessed based on
> > mm-commits mail, patch uncompiled, but should dtrt if I understood
> > your diff correctly)
> > 
> > diff --git a/lib/list_debug.c b/lib/list_debug.c
> > index 4350ba9..d8dee53 100644
> > --- a/lib/list_debug.c
> > +++ b/lib/list_debug.c
> > @@ -21,16 +21,14 @@ void __list_add(struct list_head *new,
> >  			      struct list_head *next)
> >  {
> >  	if (unlikely(next->prev != prev)) {
> > -		printk(KERN_ERR "list_add corruption. next->prev
> > should be "
> > +		WARN(1, "list_add corruption. next->prev should be
> > " "prev (%p), but was %p. (next=%p).\n",
> >  			prev, next->prev, next);
> > -		BUG();
> >  	}
> 
> I think Arjan meant like
> 
> 	WARN(next->prev != prev,
> 		"list_add corruption. next->prev should be "
> 		"prev (%p), but was %p. (next=%p).\n",
> 		prev, next->prev, next);
> 
> without any "if()" statement at all.

Dave...what Linus said ;)


would be nice to get WARN() into mainline soon... ;)