From: Andrew Morton <akpm@linux-foundation.org>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: greg@kroah.com, matthew@wil.cx, kay.sievers@vrfy.org,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/3][-mm] add class_reclassify macro
Date: Tue, 20 May 2008 10:30:45 -0700 [thread overview]
Message-ID: <20080520103045.2bb0a033.akpm@linux-foundation.org> (raw)
In-Reply-To: <a8e1da0805200405t10fae448w589449e75a5abec6@mail.gmail.com>
On Tue, 20 May 2008 19:05:21 +0800 "Dave Young" <hidave.darkstar@gmail.com> wrote:
> On Tue, May 20, 2008 at 6:02 PM, Andrew Morton
> <akpm@linux-foundation.org> wrote:
> > On Tue, 20 May 2008 17:55:54 +0800 Dave Young <hidave.darkstar@gmail.com> wrote:
> >
> >> Converting class semaphore to mutex cause lockdep warnings due to
> >> class_interface_register/unregister will possible call device_add/del
> >
> > Shouldn't we just fix that?
>
> Andrew, could you tell more?
Well what are these lockdep warnings? Normally such a warning means that
we have a locking bug. I _assume_ that you've determined that the warnings
are false-positives?
The warning which Mariusz Kozlowski discovered ("Subject: Re:
2.6.26-rc2-mm1: possible circular locking dependency detected") was
triggered by the "class semaphore to mutex" conversion and it looks
like a real bug to me. Would your patch prevent warnings such as that
one from being available to us?
next prev parent reply other threads:[~2008-05-20 17:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 9:55 [PATCH 1/3][-mm] add class_reclassify macro Dave Young
2008-05-20 10:02 ` Andrew Morton
2008-05-20 11:05 ` Dave Young
2008-05-20 17:30 ` Andrew Morton [this message]
2008-05-20 17:36 ` Matthew Wilcox
2008-05-20 19:23 ` Andrew Morton
2008-05-21 2:05 ` Dave Young
2008-05-20 11:36 ` Matthew Wilcox
2008-05-20 17:21 ` Greg KH
2008-05-27 6:42 ` Dave Young
2008-05-27 6:59 ` Andrew Morton
2008-05-27 7:31 ` Dave Young
2008-05-28 15:48 ` Matthew Wilcox
2008-05-28 16:06 ` Greg KH
2008-05-28 16:28 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080520103045.2bb0a033.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=hidave.darkstar@gmail.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.