From: "J. Bruce Fields" <bfields@fieldses.org>
To: "Talpey, Thomas" <Thomas.Talpey@netapp.com>
Cc: Tom Tucker <tom@opengridcomputing.com>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 01/05] svcrdma: Verify read-list fits within RPCSVC_MAXPAGES
Date: Tue, 20 May 2008 09:56:51 -0400 [thread overview]
Message-ID: <20080520135651.GB2373@fieldses.org> (raw)
In-Reply-To: <RTPCLUEXC1-PRDh133t00000127-rtwIt2gI0FxT+ZUat5FNkAK/GNPrWCqfQQ4Iyu8u01E@public.gmane.org>
On Tue, May 20, 2008 at 09:27:13AM -0400, Talpey, Thomas wrote:
> At 09:07 PM 5/19/2008, Tom Tucker wrote:
> >No we don't and a Byzantine client could crash us.
>
> That can be arranged... :-)
>
> >This kind of check along with a bunch of others should go in
> >svc_rdma_xdr_decode_req. I have these things planned for the 2.6.27
> >time-frame (along with Fast NSMR support).
> >
> >Do you think it's more urgent?
>
> MHO is that it's important but not urgent, and it should be part of a later
> change. At Connectathon, no clients were sending any problematic requests,
> so I think it's unlikely this will affect us in the wild, for now.
Somewhere in the documentation, a really clear warning about the
security assumptions would be useful. It could also help if the howto
(on the web and in Documentation/filesystems/nfs-rdma.txt) included any
instructions on necessary firewalling, etc.
By the way, the Kconfig help text for SUNRPC_XPRT_RDMA looks like it
needs an update to mention the server?
--b.
next prev parent reply other threads:[~2008-05-20 13:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <12111560011694-git-send-email-tom@opengridcomputing.com>
[not found] ` <12111560022506-git-send-email-tom@opengridcomputing.com>
2008-05-19 18:20 ` [PATCH 01/05] svcrdma: Verify read-list fits within RPCSVC_MAXPAGES J. Bruce Fields
2008-05-20 1:07 ` Tom Tucker
[not found] ` <1211245672.31725.111.camel-SMNkleLxa3ZimH42XvhXlA@public.gmane.org>
2008-05-20 13:27 ` Talpey, Thomas
[not found] ` <RTPCLUEXC1-PRDh133t00000127-rtwIt2gI0FxT+ZUat5FNkAK/GNPrWCqfQQ4Iyu8u01E@public.gmane.org>
2008-05-20 13:56 ` J. Bruce Fields [this message]
2008-05-20 14:14 ` Talpey, Thomas
[not found] ` <1211156002624-git-send-email-tom@opengridcomputing.com>
[not found] ` <12111560022695-git-send-email-tom@opengridcomputing.com>
[not found] ` <12111560022073-git-send-email-tom@opengridcomputing.com>
[not found] ` <12111560023250-git-send-email-tom@opengridcomputing.com>
2008-05-19 19:18 ` [PATCH 05/05] svcrdma: Add dma map count and WARN_ON J. Bruce Fields
2008-05-19 19:27 ` Tom Tucker
2008-05-21 0:46 ` [PATCH 02/05] svcrdma: Refactor RDMA_WRITE dma mapping logic J. Bruce Fields
2008-05-21 2:52 ` J. Bruce Fields
2008-05-21 10:33 ` Tom Tucker
2008-05-25 19:05 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080520135651.GB2373@fieldses.org \
--to=bfields@fieldses.org \
--cc=Thomas.Talpey@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=tom@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.