From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: David Chinner <dgc@sgi.com>
Cc: Christoph Lameter <clameter@sgi.com>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Mel Gorman <mel@skynet.ie>,
andi@firstfloor.org, Rik van Riel <riel@redhat.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
mpm@selenic.com
Subject: Re: [patch 10/21] buffer heads: Support slab defrag
Date: Wed, 21 May 2008 03:22:56 +0400 [thread overview]
Message-ID: <20080520232256.GA16105@2ka.mipt.ru> (raw)
In-Reply-To: <20080520222505.GA23988@2ka.mipt.ru>
On Wed, May 21, 2008 at 02:25:05AM +0400, Evgeniy Polyakov (johnpol@2ka.mipt.ru) wrote:
> > Oh, god no. Let's not put the inode_lock right at the top of
> > the VM page cleaning path. We don't need to modify inode state,
> > the superblock dirty lists, etc - all we need to do is write
> > dirty pages on a given mapping in a more efficient manner.
>
> I'm not advocating that, but having swap on reclaim does not hurt
> anyone, this is essentially the same, but with different underlying
> storage. System will do that anyway sooner or later during usual
> writeback, which in turn can be a result of the same reclaim...
And actually having tiny operations under inode_lock is the last thing
to worry about when we are about to start writing pages to disk because
memory is so fragmented that we need to move things around.
That is the simplest from the typing viewpoint, one can also do
something like that:
struct address_space *mapping = page->mapping;
struct backing_dev_info *bdi = mapping->backing_dev_info;
struct writeback_control wbc = {
.bdi = bdi,
.sync_mode = WB_SYNC_ALL, /* likly we want to wait... */
.older_than_this = NULL,
.nr_to_write = 13,
.range_cyclic = 0,
.range_start = start_index,
.range_end = end_index
};
do_writepages(mapping, &wbc);
Cristoph, is this example you wnated to check out? It will only try to
write .nr_to_write pages between .range_start and .range_end without
syncing inode info itself.
--
Evgeniy Polyakov
next prev parent reply other threads:[~2008-05-20 23:24 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-10 3:08 [patch 00/21] Slab Fragmentation Reduction V12 Christoph Lameter
2008-05-10 3:08 ` [patch 01/21] slub: Add defrag_ratio field and sysfs support Christoph Lameter
2008-05-10 3:08 ` [patch 02/21] slub: Replace ctor field with ops field in /sys/slab/* Christoph Lameter
2008-05-10 3:08 ` [patch 03/21] slub: Add get() and kick() methods Christoph Lameter
2008-05-10 3:08 ` [patch 04/21] slub: Sort slab cache list and establish maximum objects for defrag slabs Christoph Lameter
2008-05-10 3:08 ` [patch 05/21] slub: Slab defrag core Christoph Lameter
2008-05-10 3:08 ` [patch 06/21] slub: Add KICKABLE to avoid repeated kick() attempts Christoph Lameter
2008-05-10 3:08 ` [patch 07/21] slub: Extend slabinfo to support -D and -F options Christoph Lameter
2008-05-10 3:08 ` [patch 08/21] slub: add defrag statistics Christoph Lameter
2008-05-10 3:08 ` [patch 09/21] slub: Trigger defragmentation from memory reclaim Christoph Lameter
2008-05-10 3:08 ` [patch 10/21] buffer heads: Support slab defrag Christoph Lameter
2008-05-12 0:24 ` David Chinner
2008-05-15 17:42 ` Christoph Lameter
2008-05-15 23:10 ` David Chinner
2008-05-16 17:01 ` Christoph Lameter
2008-05-19 5:45 ` David Chinner
2008-05-19 16:44 ` Christoph Lameter
2008-05-20 0:25 ` David Chinner
2008-05-20 6:56 ` Evgeniy Polyakov
2008-05-20 21:46 ` David Chinner
2008-05-20 22:25 ` Evgeniy Polyakov
2008-05-20 23:19 ` David Chinner
2008-05-20 23:28 ` Andrew Morton
2008-05-21 6:15 ` Evgeniy Polyakov
2008-05-21 6:24 ` Andrew Morton
2008-05-21 17:52 ` iput() in reclaim context Hugh Dickins
2008-05-21 17:58 ` Evgeniy Polyakov
2008-05-21 18:12 ` Andrew Morton
2008-05-20 23:22 ` Evgeniy Polyakov [this message]
2008-05-20 23:30 ` [patch 10/21] buffer heads: Support slab defrag David Chinner
2008-05-21 6:20 ` Evgeniy Polyakov
2008-05-21 1:56 ` Christoph Lameter
2008-05-20 22:53 ` Jamie Lokier
2008-05-10 3:08 ` [patch 11/21] inodes: Support generic defragmentation Christoph Lameter
2008-05-10 3:08 ` [patch 12/21] Filesystem: Ext2 filesystem defrag Christoph Lameter
2008-05-10 3:08 ` [patch 13/21] Filesystem: Ext3 " Christoph Lameter
2008-05-10 3:08 ` [patch 14/21] Filesystem: Ext4 " Christoph Lameter
2008-05-10 3:08 ` [patch 15/21] Filesystem: XFS slab defragmentation Christoph Lameter
2008-05-10 6:55 ` Christoph Hellwig
2008-05-10 3:08 ` [patch 16/21] Filesystem: /proc filesystem support for slab defrag Christoph Lameter
2008-05-10 3:08 ` [patch 17/21] Filesystem: Slab defrag: Reiserfs support Christoph Lameter
2008-05-10 3:08 ` [patch 18/21] Filesystem: Socket inode defragmentation Christoph Lameter
2008-05-13 13:28 ` Evgeniy Polyakov
2008-05-15 17:40 ` Christoph Lameter
2008-05-15 18:23 ` Evgeniy Polyakov
2008-05-10 3:08 ` [patch 19/21] dentries: Add constructor Christoph Lameter
2008-05-10 3:08 ` [patch 20/21] dentries: dentry defragmentation Christoph Lameter
2008-05-10 3:08 ` [patch 21/21] slab defrag: Obsolete SLAB Christoph Lameter
2008-05-10 9:53 ` Andi Kleen
2008-05-11 2:15 ` Rik van Riel
2008-05-12 7:38 ` KOSAKI Motohiro
2008-05-12 7:54 ` Pekka Enberg
2008-05-12 10:08 ` Andi Kleen
2008-05-12 10:23 ` Pekka Enberg
2008-05-14 17:30 ` Christoph Lameter
2008-05-14 17:29 ` Christoph Lameter
2008-05-14 17:49 ` Andi Kleen
2008-05-14 18:03 ` Christoph Lameter
2008-05-14 18:18 ` Matt Mackall
2008-05-14 19:21 ` Christoph Lameter
2008-05-14 19:49 ` Matt Mackall
2008-05-14 20:33 ` Christoph Lameter
2008-05-14 21:02 ` Matt Mackall
2008-05-14 21:26 ` Christoph Lameter
2008-05-14 21:54 ` Matt Mackall
2008-05-15 17:15 ` Christoph Lameter
2008-05-15 3:26 ` Zhang, Yanmin
2008-05-15 3:26 ` Zhang, Yanmin
2008-05-15 17:05 ` Christoph Lameter
2008-05-15 17:49 ` Matthew Wilcox
2008-05-15 17:58 ` Christoph Lameter
2008-05-15 18:13 ` Matthew Wilcox
2008-05-15 18:43 ` Christoph Lameter
2008-05-15 18:51 ` Matthew Wilcox
2008-05-15 19:09 ` Christoph Lameter
2008-05-15 19:29 ` Matthew Wilcox
2008-05-15 20:14 ` Matthew Wilcox
2008-05-15 20:30 ` Pekka Enberg
2008-05-16 19:17 ` Christoph Lameter
2008-05-16 19:06 ` Christoph Lameter
2008-05-15 18:19 ` Eric Dumazet
2008-05-15 18:19 ` Eric Dumazet
2008-05-15 18:29 ` Vegard Nossum
2008-05-16 5:16 ` Zhang, Yanmin
2008-05-16 5:16 ` Zhang, Yanmin
2008-05-14 18:05 ` Christoph Lameter
2008-05-14 20:46 ` Christoph Lameter
2008-05-14 20:58 ` Matthew Wilcox
2008-05-14 21:00 ` Christoph Lameter
2008-05-14 21:21 ` Matthew Wilcox
2008-05-14 21:33 ` Christoph Lameter
2008-05-14 21:43 ` Matthew Wilcox
2008-05-14 21:53 ` Christoph Lameter
2008-05-14 22:00 ` Matthew Wilcox
2008-05-14 22:32 ` Christoph Lameter
2008-05-14 22:34 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080520232256.GA16105@2ka.mipt.ru \
--to=johnpol@2ka.mipt.ru \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=clameter@sgi.com \
--cc=dgc@sgi.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@skynet.ie \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.