From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936685AbYEURrd (ORCPT ); Wed, 21 May 2008 13:47:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1765382AbYEURrZ (ORCPT ); Wed, 21 May 2008 13:47:25 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:45778 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753738AbYEURrY (ORCPT ); Wed, 21 May 2008 13:47:24 -0400 Date: Wed, 21 May 2008 10:46:44 -0700 From: Andrew Morton To: Theodore Tso Cc: Christoph Hellwig , Al Viro , linux-kernel@vger.kernel.org, davem@davemloft.net Subject: Re: CFD: linux-wanking@vger.kernel.org (was [PATCH] Standard indentation of arguments) Message-Id: <20080521104644.5b6f4e63.akpm@linux-foundation.org> In-Reply-To: <20080521120939.GF8581@mit.edu> References: <12113495282137-git-send-email-kongjianjun@gmail.com> <20080521083413.GM28946@ZenIV.linux.org.uk> <20080521015037.add0b78e.akpm@linux-foundation.org> <20080521103206.GA24545@infradead.org> <20080521120939.GF8581@mit.edu> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 21 May 2008 08:09:39 -0400 Theodore Tso wrote: > On Wed, May 21, 2008 at 06:32:06AM -0400, Christoph Hellwig wrote: > > On Wed, May 21, 2008 at 01:50:37AM -0700, Andrew Morton wrote: > > > Oh, what a marvellous way to encourage new contributors that was. Thank > > > you so much. > > > > > > For the record: Al speaks only for himself and a lack of expressed > > > disagrement from others should not be taken as agreement. > > > > But I'd like to second the opinion. This is getting a little too far. > > We should rather try to at least enforce very basic standards a lot of > > the crap shoved in doesn't follow instead of wanking around about exact > > placement of whitespaces. > > The real question is whether people who are wanking about whitespace > and spelling fixes in comments will graduate to writing real, useful > patches. If they won't, there's no point to encouraging them. > Guys, get a clue. It doesn't matter what that person did. It is the effect upon *all* other potential developers which is so damaging here. Not upon this individual.