All of lore.kernel.org
 help / color / mirror / Atom feed
From: Octavian Purdila <opurdila@ixiacom.com>
To: netdev@vger.kernel.org
Subject: Re: [PATCH] Fix frag list handling in TCP splice receive
Date: Wed, 21 May 2008 11:05:03 +0300	[thread overview]
Message-ID: <200805211105.03947.opurdila@ixiacom.com> (raw)
In-Reply-To: <200805171636.07443.opurdila@ixiacom.com>

On Saturday 17 May 2008, Octavian Purdila wrote:
> If an skb does not have fragments but its fragment list is not empty (can
> happen, via LRO at least) and a previous tcp_read_sock has consumed
> the linear part of the skb then __skb_splice_bits:
>
> (a) incorrectly reports an error and
>
> (b) forgets to update the offset to account for the linear part
>
> Any of the two problems will cause the subsequent __skb_splice_bits call
> (the one that handles the fragment list skbs) to either skip data, or, if
> the unadjusted offset is greater then the size of the next skb, make
> tcp_splice_read loop forever.
>

Hi,

Any comments, please?

Patch for 2.6.25 is here:

http://www.spinics.net/lists/netdev/msg63541.html

Thanks,
tavi

  reply	other threads:[~2008-05-21  8:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-17 13:36 [PATCH] Fix frag list handling in TCP splice receive Octavian Purdila
2008-05-21  8:05 ` Octavian Purdila [this message]
2008-05-21  8:13   ` David Miller
2008-05-21 12:31     ` Octavian Purdila

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200805211105.03947.opurdila@ixiacom.com \
    --to=opurdila@ixiacom.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.