From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Daniel P. Berrange" Subject: Re: [PATCH]Remove XendLogging dependency from xswatch Date: Wed, 21 May 2008 14:10:13 +0100 Message-ID: <20080521131013.GB3915@redhat.com> References: <4833B4CB.3090001@oracle.com> Reply-To: "Daniel P. Berrange" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4833B4CB.3090001@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Zhigang Wang Cc: xen-devel List-Id: xen-devel@lists.xenproject.org On Wed, May 21, 2008 at 01:36:11PM +0800, Zhigang Wang wrote: > Hi, > > xstransact and xswatch are well designed python interface that can be used by > third party utils rather than only in xend. But the logging approach here binds > xswatch to xend and prevent it from being used by other utils. > > This patch removes the dependency on XendLogging from xswatch. Instead of doing from xen.xend.XendLogging import log ... log.debug("Blah") All the code could just use Python's real logging API directly avoiding the Xen specific code which doesn't really add any value here. eg import logging logging.debug("Blah") Dan. -- |: Red Hat, Engineering, Boston -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|