All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gary Hade <garyhade@us.ibm.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Gary Hade <garyhade@us.ibm.com>,
	Yinghai Lu <yhlu.kernel@gmail.com>,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: boot parameter to avoid expansion ROM memory allocation
Date: Wed, 21 May 2008 10:29:56 -0700	[thread overview]
Message-ID: <20080521172956.GA8024@us.ibm.com> (raw)
In-Reply-To: <200805201316.33882.jbarnes@virtuousgeek.org>

On Tue, May 20, 2008 at 01:16:33PM -0700, Jesse Barnes wrote:
> On Tuesday, May 20, 2008 1:00 pm Gary Hade wrote:
> > On Tue, May 20, 2008 at 10:57:49AM -0700, Jesse Barnes wrote:
> > > On Wednesday, May 14, 2008 9:20 am Gary Hade wrote:
> > > > > Correct, not a perfect solution but better than we have right now.
> > > >
> > > > ...but don't let this comment make you think that I am not in
> > > > favor of something like you are suggesting.  I am interested
> > > > in getting the 'pci=norom' change into mainline quickly but it
> > > > is obviously less than ideal for the long term.
> > > >
> > > > Jesse, any idea how many different devices absolutely need
> > > > memory allocated for their expansion ROMs?
> > >
> > > Unless there's a ton of demand, I'd rather go with the norom option, but
> > > either way, I'd like to push the fix early in the 2.6.27 cycle rather
> > > than trying to get it into 2.6.26 at the last minute...
> >
> > This is fine.  I would also like to see the pci=norom option
> > added as-is with the thought that we may improve later by either
> > modifying pci=norom to exclude devices that need memory mapped
> > to their expansion ROMs or by adding another option (pci=minrom ?)
> > that would do the same thing.
> >
> > > So assuming you're ok with your last patch, I'll stuff it into
> > > linux-next.
> >
> > Works for me.  Thanks.
> 
> Ok, just pushed the norom patch to linux-next.  I'll test it out, but it would 
> be good if you could try the tree out out on one of the problem machines too.

Jesse, I just tried 2.6.26-rc3-next-20080521 on one of
those systems and the pci=norom option worked as expected.

Thanks,
Gary

-- 
Gary Hade
System x Enablement
IBM Linux Technology Center
503-578-4503  IBM T/L: 775-4503
garyhade@us.ibm.com
http://www.ibm.com/linux/ltc

  reply	other threads:[~2008-05-21 17:30 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-12 20:57 [PATCH] PCI: boot parameter to avoid expansion ROM memory allocation Gary Hade
2008-05-12 21:43 ` Yinghai Lu
2008-05-12 22:30   ` Gary Hade
2008-05-13 17:48     ` Yinghai Lu
2008-05-13 21:00       ` Gary Hade
2008-05-13 21:11         ` Yinghai Lu
2008-05-13 21:44           ` Yinghai Lu
2008-05-13 22:28           ` Jesse Barnes
2008-05-13 23:23             ` Yinghai Lu
2008-05-14  0:07               ` Gary Hade
2008-05-14 16:20                 ` Gary Hade
2008-05-14 16:58                   ` [RFC] which drivers need to map ROM BARs? Jesse Barnes
2008-05-20 17:57                   ` [PATCH] PCI: boot parameter to avoid expansion ROM memory allocation Jesse Barnes
2008-05-20 20:00                     ` Gary Hade
2008-05-20 20:16                       ` Jesse Barnes
2008-05-21 17:29                         ` Gary Hade [this message]
2008-05-21 17:40                           ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080521172956.GA8024@us.ibm.com \
    --to=garyhade@us.ibm.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.