From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH] usb-storage: don't call utsname() Date: Wed, 21 May 2008 11:09:57 -0700 Message-ID: <20080521180957.GA17598@kroah.com> References: <20080521123700.GA8770@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Matthew Dharm , Christoph Hellwig , "Frank Ch. Eigler" , Adrian Bunk , USB Storage list , Kernel development list , "David S. Miller" , systemtap-R2MHTz/CkKAf7BdofF/totBPR1lH4CV8@public.gmane.org, Andrew Morton , linux-cifs-client@lists.samba.org, linux-nfs@vger.kernel.org To: Alan Stern Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:57259 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932579AbYEUSKe (ORCPT ); Wed, 21 May 2008 14:10:34 -0400 In-Reply-To: Sender: linux-nfs-owner@vger.kernel.org List-ID: On Wed, May 21, 2008 at 01:51:17PM -0400, Alan Stern wrote: > This patch (as1100) replaces the core-kernel function call to utsname() > in usb-storage with the UTS_RELEASE macro. It's used only for warning > about extra unusual_devs entries. > > Signed-off-by: Alan Stern Why? With this change, if you change the version number, the file will have to be rebuilt. Without the change, the file will not need to be rebuilt, right? I thought that was why this change was made a while ago, to prevent things from having to be rebuilt that didn't need to be. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936202AbYEUSKo (ORCPT ); Wed, 21 May 2008 14:10:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932733AbYEUSKg (ORCPT ); Wed, 21 May 2008 14:10:36 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:57259 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932579AbYEUSKe (ORCPT ); Wed, 21 May 2008 14:10:34 -0400 Date: Wed, 21 May 2008 11:09:57 -0700 From: Greg KH To: Alan Stern Cc: Matthew Dharm , Christoph Hellwig , "Frank Ch. Eigler" , Adrian Bunk , USB Storage list , Kernel development list , "David S. Miller" , systemtap@sources.redhat.com, Andrew Morton , linux-cifs-client@lists.samba.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH] usb-storage: don't call utsname() Message-ID: <20080521180957.GA17598@kroah.com> References: <20080521123700.GA8770@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 21, 2008 at 01:51:17PM -0400, Alan Stern wrote: > This patch (as1100) replaces the core-kernel function call to utsname() > in usb-storage with the UTS_RELEASE macro. It's used only for warning > about extra unusual_devs entries. > > Signed-off-by: Alan Stern Why? With this change, if you change the version number, the file will have to be rebuilt. Without the change, the file will not need to be rebuilt, right? I thought that was why this change was made a while ago, to prevent things from having to be rebuilt that didn't need to be. thanks, greg k-h