From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] usb-storage: don't call utsname() Date: Wed, 21 May 2008 14:52:51 -0400 Message-ID: <20080521185251.GA783@infradead.org> References: <20080521123700.GA8770@infradead.org> <20080521180957.GA17598@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Alan Stern , Matthew Dharm , Christoph Hellwig , "Frank Ch. Eigler" , Adrian Bunk , USB Storage list , Kernel development list , "David S. Miller" , systemtap-R2MHTz/CkKAf7BdofF/totBPR1lH4CV8@public.gmane.org, Andrew Morton , linux-cifs-client@lists.samba.org, linux-nfs@vger.kernel.org To: Greg KH Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:40242 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936405AbYEUSxK (ORCPT ); Wed, 21 May 2008 14:53:10 -0400 In-Reply-To: <20080521180957.GA17598@kroah.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Wed, May 21, 2008 at 11:09:57AM -0700, Greg KH wrote: > Why? With this change, if you change the version number, the file will > have to be rebuilt. Without the change, the file will not need to be > rebuilt, right? Because thanks to the container patches it utsname fields other than hostname can actually change at runtime now and you'll get races looking at them. And probably not the output you want if someone in your container changes the kernel version to trick applications. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936833AbYEUSyB (ORCPT ); Wed, 21 May 2008 14:54:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S936687AbYEUSxL (ORCPT ); Wed, 21 May 2008 14:53:11 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:40242 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936405AbYEUSxK (ORCPT ); Wed, 21 May 2008 14:53:10 -0400 Date: Wed, 21 May 2008 14:52:51 -0400 From: Christoph Hellwig To: Greg KH Cc: Alan Stern , Matthew Dharm , Christoph Hellwig , "Frank Ch. Eigler" , Adrian Bunk , USB Storage list , Kernel development list , "David S. Miller" , systemtap@sources.redhat.com, Andrew Morton , linux-cifs-client@lists.samba.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH] usb-storage: don't call utsname() Message-ID: <20080521185251.GA783@infradead.org> References: <20080521123700.GA8770@infradead.org> <20080521180957.GA17598@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080521180957.GA17598@kroah.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 21, 2008 at 11:09:57AM -0700, Greg KH wrote: > Why? With this change, if you change the version number, the file will > have to be rebuilt. Without the change, the file will not need to be > rebuilt, right? Because thanks to the container patches it utsname fields other than hostname can actually change at runtime now and you'll get races looking at them. And probably not the output you want if someone in your container changes the kernel version to trick applications.