All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Mundt <lethal@linux-sh.org>
To: Pekka J Enberg <penberg@cs.helsinki.fi>
Cc: linux-kernel@vger.kernel.org, clameter@sgi.com, mpm@selenic.com,
	dhowells@redhat.com
Subject: Re: [RFC/PATCH 1/3] SLAB: Add PageSlab checking to ksize()
Date: Thu, 22 May 2008 08:45:55 +0900	[thread overview]
Message-ID: <20080521234555.GB32707@linux-sh.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0805212124250.22291@sbz-30.cs.Helsinki.FI>

On Wed, May 21, 2008 at 09:25:26PM +0300, Pekka J Enberg wrote:
> From: Pekka Enberg <penberg@cs.helsinki.fi>
> 
> The ksize() function is meant for objects allocated from the slab caches, not
> for arbitrary objects. Add a BUG_ON() to enforce that.
> 
> Cc: Christoph Lameter <clameter@sgi.com>
> Cc: Matt Mackall <mpm@selenic.com>
> Cc: Paul Mundt <lethal@linux-sh.org>
> Cc: David Howells <dhowells@redhat.com>
> Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>

This series seems to work ok with all of SLAB/SLUB/SLOB when also
applying the kobjsize() patch. Without the kobjsize() patch in place,
SLAB and SLUB both work, while SLOB still triggers the >= MAX_ORDER
BUG_ON() for page cache pages. Note that this is still an improvement
over SLUB blowing up, as it was before, even without the kobjsize()
change.

  reply	other threads:[~2008-05-21 23:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-21 18:25 [RFC/PATCH 1/3] SLAB: Add PageSlab checking to ksize() Pekka J Enberg
2008-05-21 23:45 ` Paul Mundt [this message]
2008-05-22  4:13   ` Pekka Enberg
2008-05-22  4:17     ` Christoph Lameter
2008-05-22  4:21       ` Pekka Enberg
2008-05-22  4:34         ` Paul Mundt
2008-05-22  4:43           ` Pekka Enberg
2008-05-22  4:55             ` Paul Mundt
2008-05-22 15:01             ` Matt Mackall
2008-05-22 16:13               ` Pekka Enberg
2008-05-22 16:51                 ` Christoph Lameter
2008-05-22 18:31                 ` Matt Mackall
2008-05-23 14:23                 ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080521234555.GB32707@linux-sh.org \
    --to=lethal@linux-sh.org \
    --cc=clameter@sgi.com \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpm@selenic.com \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.